From: Luciano Coelho <luciano.coelho@nokia.com>
To: "ext John W. Linville" <linville@tuxdriver.com>
Cc: "Luis R. Rodriguez" <mcgrof@gmail.com>,
Kalle Valo <kalle.valo@iki.fi>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: Revised wireless tree management practices
Date: Mon, 14 Dec 2009 14:32:35 +0200 [thread overview]
Message-ID: <4B263063.4030000@nokia.com> (raw)
In-Reply-To: <20091210162517.GD2955@tuxdriver.com>
ext John W. Linville wrote:
> On Thu, Dec 10, 2009 at 08:14:34AM -0800, Luis R. Rodriguez wrote:
>> On Thu, Dec 10, 2009 at 7:03 AM, John W. Linville
>> <linville@tuxdriver.com> wrote:
>
>>> Yes. If you want me to do git pulls then you need to separate fixes
>>> into a tree based on wireless-2.6. Also, you should be conscientious
>>> about adding "Cc: stable@kernel.org" to commit logs as appropriate.
>>> The whole point of the pulls is to keep me from having to touch
>>> the patches.
>> OK last question, is if we do take up the pull request method for
>> ath9k at Atheros we still have people sending patches from the
>> community so who would pick those up. Is it easier for you if we do so
>> and then get them to you through our pull request? How about the
>> stable fixes? Reason I ask if you pick some of these up it just means
>> we need to rebase and I do prefer to keep a clean tree myself as well,
>> although not required at all.
>
> In the generic case, the driver/subsystem maintainer and I should
> negotiate that in advance -- either way might be acceptable and either
> way might call for special cases for individual patches.
>
> So, feel free to propose how you would like to do it for ath9k in
> another thread or a private email. But in general I would think that
> letting "outsider" (for lack of a better term) patches flow through
> a driver/subsystem maintainer tree would be acceptable. After all,
> that implies a higher level of domain-specific review.
This is cool! I might consider sending pull-reqs for the wl1271 driver as well,
so I don't send these patchbombs every now and then. ;) The advantage of this is
that we can have a review round before the patches actually go in. So we as the
driver/subsystem maintainers can decide when the patches are ready to go to
wireless-next-2.6.
Now it's my turn to ask a question... What happens in the case when there is an
API change, say, in mac80211 that requires changes in a few different drivers?
Those changes are usually done in a single patch that changes both the API and
the affected drivers in one go. In this case we will end up having to rebase
our own trees.
How is this done in higher levels, for instance when something that changed in
the net subsystem requires changes in the wireless "sub-subsystem"?
--
Cheers,
Luca.
next prev parent reply other threads:[~2009-12-14 12:33 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-09 21:10 Revised wireless tree management practices John W. Linville
2009-12-10 0:51 ` David Miller
2009-12-10 13:38 ` Kalle Valo
2009-12-10 13:47 ` John W. Linville
2009-12-10 14:04 ` Kalle Valo
2009-12-10 14:31 ` Luis R. Rodriguez
2009-12-10 14:37 ` John W. Linville
2009-12-10 14:53 ` Luis R. Rodriguez
2009-12-10 15:03 ` John W. Linville
2009-12-10 16:14 ` Luis R. Rodriguez
2009-12-10 16:25 ` John W. Linville
2009-12-14 12:32 ` Luciano Coelho [this message]
2009-12-14 12:40 ` David Miller
2009-12-14 13:52 ` John W. Linville
2009-12-14 14:16 ` Bartlomiej Zolnierkiewicz
2009-12-14 14:26 ` John W. Linville
2009-12-14 14:59 ` Bartlomiej Zolnierkiewicz
2009-12-14 15:23 ` David Miller
2009-12-14 16:20 ` Bartlomiej Zolnierkiewicz
2009-12-14 18:03 ` David Miller
2009-12-14 18:24 ` Bartlomiej Zolnierkiewicz
2009-12-14 18:41 ` David Miller
2009-12-14 19:16 ` Bartlomiej Zolnierkiewicz
2009-12-14 19:23 ` David Miller
2009-12-14 19:42 ` Bartlomiej Zolnierkiewicz
2009-12-14 19:46 ` David Miller
2009-12-14 20:09 ` Bartlomiej Zolnierkiewicz
2009-12-14 15:19 ` David Miller
2009-12-14 16:18 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B263063.4030000@nokia.com \
--to=luciano.coelho@nokia.com \
--cc=davem@davemloft.net \
--cc=kalle.valo@iki.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).