From: Gertjan van Wingerde <gwingerde@gmail.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org, Ivo van Doorn <ivdoorn@gmail.com>,
Randy Dunlap <randy.dunlap@oracle.com>
Subject: Re: [PATCH] rt2x00: Fix rt2800usb detection in rt2800lib.
Date: Mon, 14 Dec 2009 20:24:16 +0100 [thread overview]
Message-ID: <4B2690E0.6050604@gmail.com> (raw)
In-Reply-To: <1260818004-22785-1-git-send-email-linville@tuxdriver.com>
On 12/14/09 20:13, John W. Linville wrote:
> From: Gertjan van Wingerde <gwingerde@gmail.com>
>
> rt2800lib incorrectly detected whether RT2800USB was enabled because
> it didn't account for a modularized RT2800USB driver.
>
> Signed-off-by: Gertjan van Wingerde <gwingerde@gmail.com>
> Acked-by: Ivo van Doorn <IvDoorn@gmail.com>
> ---
> I'm merging this version based on Randy's feedback...
>
> drivers/net/wireless/rt2x00/rt2800lib.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
> index eb1e1d0..6e13650 100644
> --- a/drivers/net/wireless/rt2x00/rt2800lib.c
> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
> @@ -37,7 +37,7 @@
> #include <linux/module.h>
>
> #include "rt2x00.h"
> -#ifdef CONFIG_RT2800USB
> +#if defined(CONFIG_RT2800USB) || defined(CONFIG_RT2800USB_MODULE)
> #include "rt2x00usb.h"
> #endif
> #include "rt2800lib.h"
> @@ -1121,7 +1121,7 @@ int rt2800_init_registers(struct rt2x00_dev *rt2x00dev)
>
> if (rt2x00_intf_is_usb(rt2x00dev)) {
> rt2800_register_write(rt2x00dev, USB_DMA_CFG, 0x00000000);
> -#ifdef CONFIG_RT2800USB
> +#if defined(CONFIG_RT2800USB) || defined(CONFIG_RT2800USB_MODULE)
> rt2x00usb_vendor_request_sw(rt2x00dev, USB_DEVICE_MODE, 0,
> USB_MODE_RESET, REGISTER_TIMEOUT);
> #endif
Thanks, looks good to me.
---
Gertjan.
prev parent reply other threads:[~2009-12-14 21:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-12 23:39 [PATCH 2.6.33] rt2x00: Fix rt2800usb detection in rt2800lib Gertjan van Wingerde
2009-12-12 23:39 ` [PATCH 2.6.33] rt2x00: Disable powersaving for rt61pci Gertjan van Wingerde
2009-12-13 10:15 ` Ivo van Doorn
2009-12-13 15:16 ` Gertjan van Wingerde
2009-12-13 15:18 ` Ivo van Doorn
2009-12-13 15:21 ` Gertjan van Wingerde
2009-12-13 15:45 ` [rt2x00-users] " Benoit PAPILLAULT
2009-12-14 19:27 ` Gertjan van Wingerde
2009-12-13 3:54 ` [PATCH 2.6.33] rt2x00: Fix rt2800usb detection in rt2800lib Randy Dunlap
2009-12-13 10:14 ` Ivo van Doorn
2009-12-14 19:13 ` [PATCH] " John W. Linville
2009-12-14 19:24 ` Gertjan van Wingerde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B2690E0.6050604@gmail.com \
--to=gwingerde@gmail.com \
--cc=ivdoorn@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).