linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Gertjan van Wingerde <gwingerde@gmail.com>
To: Markus Baier <Markus_Baier@web.de>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [BISECTED] [PATCH v2 8/8] rt2x00: Properly request tx headroom for alignment operations.
Date: Sun, 20 Dec 2009 21:20:57 +0100	[thread overview]
Message-ID: <4B2E8729.7050501@gmail.com> (raw)
In-Reply-To: <loom.20091220T163829-137@post.gmane.org>

On 12/20/09 16:42, Markus Baier wrote:
> After my latest git pull to the kernel version 2.6.33-rc1-wl
> no client was able to connect to my hostapd (v0.6.9) AP.
> I found a lot of the following entries in the syslog:
> 
> wlan0: STA xx:xx:xx:xx:xx:xx
> IEEE 802.11: did not acknowledge authentication response
> 
> I bisected the problem to the commit e77f5ff92f5ef43c842e97136edcb68c61afe588
> above.
> 
> After I removed the lines below in rt2x00dev.c:
> rt2x00dev->hw->extra_tx_headroom =
>         max_t(unsigned int, IEEE80211_TX_STATUS_HEADROOM,
>               rt2x00dev->ops->extra_tx_headroom);
> 
> /*
> * Take TX headroom required for alignment into account.
> */
> if (test_bit(DRIVER_REQUIRE_L2PAD, &rt2x00dev->flags))
>         rt2x00dev->hw->extra_tx_headroom += RT2X00_L2PAD_SIZE;
> else if (test_bit(DRIVER_REQUIRE_DMA, &rt2x00dev->flags))
>         rt2x00dev->hw->extra_tx_headroom += RT2X00_ALIGN_SIZE;
> 
> added the line:
> rt2x00dev->hw->extra_tx_headroom = rt2x00dev->ops->extra_tx_headroom;
> 
> and compiled the kernel 2.6.33-rc2 again, all worked fine.
> 

That is very strange as this patch was meant to send TX statuses of frames
towards monitor interfaces (which is what hostapd is using).

What kind of rt2x00 device are you using (and which of the rt2x00 drivers)?

Are there any messages in dmesg when this happens?
Can you check whether there are any messages in dmesg in the working situation?

---
Gertjan.

  reply	other threads:[~2009-12-20 20:20 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-23 21:44 [PATCH v2 0/8] Assorted fixes and cleanups for rt2x00 and mac80211 Gertjan van Wingerde
2009-11-23 21:44 ` [PATCH v2 1/8] rt2x00: Only initialize HT on rt2800 devices that support it Gertjan van Wingerde
2009-11-23 21:44   ` [PATCH v2 2/8] rt2x00: Remove unused variable frame_control from rt2x00mac_tx Gertjan van Wingerde
2009-11-23 21:44     ` [PATCH v2 3/8] rt2x00: Clean up use of rt2x00_intf_is_pci Gertjan van Wingerde
2009-11-23 21:44       ` [PATCH v2 4/8] rt2x00: Fix typo (lengt --> length) in rt2x00queue.c Gertjan van Wingerde
2009-11-23 21:44         ` [PATCH v2 5/8] rt2x00: Whitespace cleanup Gertjan van Wingerde
2009-11-23 21:44           ` [PATCH v2 6/8] rt2x00: Centralize setting of extra TX headroom requested by rt2x00 Gertjan van Wingerde
2009-11-23 21:44             ` [PATCH v2 7/8] mac80211: Add define for TX headroom reserved by mac80211 itself Gertjan van Wingerde
2009-11-23 21:44               ` [PATCH v2 8/8] rt2x00: Properly request tx headroom for alignment operations Gertjan van Wingerde
2009-11-24 17:19                 ` Ivo van Doorn
2009-11-24 19:12                   ` Gertjan van Wingerde
2009-11-24 20:04                     ` Ivo van Doorn
2009-11-25 19:47                 ` John W. Linville
2009-11-25 21:29                   ` Gertjan van Wingerde
2009-11-25 21:48                     ` John W. Linville
2009-12-20 15:42                 ` [BISECTED] " Markus Baier
2009-12-20 20:20                   ` Gertjan van Wingerde [this message]
2009-12-21  0:45                     ` Markus Baier
2009-12-21  6:33                     ` Pavel Roskin
2009-12-21 16:26                       ` Gertjan van Wingerde
2009-12-21 19:17                         ` John W. Linville
2009-12-22  0:22                           ` Gertjan van Wingerde
2009-12-22  5:25                         ` Pavel Roskin
2009-12-22  8:13                           ` Gertjan van Wingerde
2009-12-22 10:55                             ` Markus Baier
2009-12-22 14:18                               ` Gertjan van Wingerde
2009-12-22 15:03                             ` Pavel Roskin
2009-11-23 23:22               ` [PATCH v2 7/8] mac80211: Add define for TX headroom reserved by mac80211 itself Johannes Berg
2009-11-24 17:13             ` [PATCH v2 6/8] rt2x00: Centralize setting of extra TX headroom requested by rt2x00 Ivo van Doorn
2009-11-24 17:13           ` [PATCH v2 5/8] rt2x00: Whitespace cleanup Ivo van Doorn
2009-11-23 22:18   ` [rt2x00-users] [PATCH v2 1/8] rt2x00: Only initialize HT on rt2800 devices that support it David Ellingsworth
2009-11-24 17:12     ` Ivo van Doorn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B2E8729.7050501@gmail.com \
    --to=gwingerde@gmail.com \
    --cc=Markus_Baier@web.de \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).