From: Jiri Slaby <jirislaby@gmail.com>
To: Gertjan van Wingerde <gwingerde@gmail.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] NET: wireless, fix memory leak
Date: Wed, 06 Jan 2010 20:14:21 +0100 [thread overview]
Message-ID: <4B44E10D.7090802@gmail.com> (raw)
In-Reply-To: <4B44DF84.80206@gmail.com>
On 01/06/2010 08:07 PM, Gertjan van Wingerde wrote:
> On 01/06/10 17:35, Jiri Slaby wrote:
>> @@ -717,6 +717,9 @@ int cfg80211_wext_siwscan(struct net_device *dev,
>> out:
>> cfg80211_unlock_rdev(rdev);
>> return err;
>> +out_free:
>> + kfree(creq);
>> + goto out;
>> }
>> EXPORT_SYMBOL_GPL(cfg80211_wext_siwscan);
>>
>
> This last part looks a bit strange. Why don't you put out_free label before out label,
Because `out' is a part of non-error flow, where the creq should not be
freed.
thanks,
--
js
next prev parent reply other threads:[~2010-01-06 19:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-06 16:35 [PATCH 1/2] net: wireless, fix lock imbalance Jiri Slaby
2010-01-06 16:35 ` [PATCH 2/2] NET: wireless, fix memory leak Jiri Slaby
2010-01-06 17:43 ` Luis R. Rodriguez
2010-01-06 19:07 ` Gertjan van Wingerde
2010-01-06 19:14 ` Jiri Slaby [this message]
2010-01-06 17:44 ` [PATCH 1/2] net: wireless, fix lock imbalance Luis R. Rodriguez
2010-01-06 19:55 ` John W. Linville
2010-01-06 20:30 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B44E10D.7090802@gmail.com \
--to=jirislaby@gmail.com \
--cc=gwingerde@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).