From: Felix Fietkau <nbd@openwrt.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Thomas Backlund <tmb@mandriva.org>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2.6.33] mac80211: fix skb buffering issue
Date: Wed, 06 Jan 2010 23:03:17 +0100 [thread overview]
Message-ID: <4B4508A5.8050501@openwrt.org> (raw)
In-Reply-To: <1262814684.4437.0.camel@johannes.local>
On 2010-01-06 10:51 PM, Johannes Berg wrote:
> On Wed, 2010-01-06 at 23:26 +0200, Thomas Backlund wrote:
>
>> With this patch applied to 2.6.33-rc3 kernel crashes at boot...
>>
>> I have a iwl4965 connecting to a wpa2-psk encrypted network, arch is
>> x86_64, distro Mandriva Linux and the kernel has preempt enabled.
>>
>> Am I only missing some patches, or did I hit a real bug ?
>
> It'd help if you said what crashes and how since nobody else seems to be
> having that particular problem with this patch.
I have an idea.
The patch adds the following chunk of code:
> + if (!sta && ra && !is_multicast_ether_addr(ra)) {
> + sta = sta_info_get(sdata, ra);
> + if (sta)
> + sta_flags = get_sta_flags(sta);
In wireless-testing, sta_info_get takes sdata as first argument, in
2.6.33-rc3 it expects a pointer to local. This should have emitted a
compiler warning... I saw the same thing when applying the patch to an
older compat-wireless snapshot.
- Felix
next prev parent reply other threads:[~2010-01-06 22:03 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-05 17:00 [PATCH 2.6.33] mac80211: fix skb buffering issue Johannes Berg
2010-01-05 17:16 ` John W. Linville
2010-01-05 18:36 ` Lennert Buytenhek
2010-01-05 19:07 ` Felix Fietkau
2010-01-05 19:36 ` Lennert Buytenhek
2010-01-06 11:32 ` Lennert Buytenhek
2010-01-06 5:30 ` Larry Finger
2010-01-06 11:05 ` Johannes Berg
2010-01-06 18:16 ` Larry Finger
2010-01-06 11:33 ` Lennert Buytenhek
2010-01-06 21:26 ` Thomas Backlund
2010-01-06 21:51 ` Johannes Berg
2010-01-06 22:03 ` Felix Fietkau [this message]
2010-01-06 22:39 ` Thomas Backlund
2010-01-06 23:19 ` Thomas Backlund
2010-01-07 6:57 ` Johannes Berg
2010-01-07 10:41 ` Thomas Backlund
2010-01-06 22:31 ` Sedat Dilek
2010-01-07 4:10 ` Lennert Buytenhek
2010-01-07 9:24 ` Sedat Dilek
2010-01-07 14:01 ` mac80211: fix queue selection for packets injected via monitor interface Lennert Buytenhek
2010-01-07 15:45 ` Luis R. Rodriguez
2010-01-07 15:47 ` Lennert Buytenhek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4508A5.8050501@openwrt.org \
--to=nbd@openwrt.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=tmb@mandriva.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).