From: Larry Finger <Larry.Finger@lwfinger.net>
To: tim.gardner@canonical.com
Cc: Michael Buesch <mb@bu3sch.de>,
Martin Pitt <martin.pitt@ubuntu.com>,
stefano.brivio@polimi.it, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] b43: Declare all possible firmware files.
Date: Fri, 08 Jan 2010 21:47:14 -0600 [thread overview]
Message-ID: <4B47FC42.2050502@lwfinger.net> (raw)
In-Reply-To: <4B47D98F.1000703@canonical.com>
On 01/08/2010 07:19 PM, Tim Gardner wrote:
> Michael Buesch wrote:
>> On Friday 08 January 2010 18:32:48 Martin Pitt wrote:
>>> Tim Gardner [2010-01-07 12:43 -0700]:
>>>> AFAIK Jockey only needs to be able to tell if _any_ of the firmware
>>>> files have been installed and could therefore make an install decision
>>>> based on just one firmware file name.
>>> Correct.
>>>
>>>> Martin - if thats the case, then we need only list one firmware file in
>>>> the modinfo, correct?
>>> Right. If that's not practical to fix on the kernel side for some
>>> reason, we could also put in a quirk into the Broadcom handler in
>>> update-notifier. (Right now it just listens for FIRMWARE subsystem
>>> uevents and checksc if the value of it exists as a file).
>>>
>>> This was originally introduced for the DVB-T driver firmware packages,
>>> but if we could make it work for b43 as well, this would be nice.
>>
>> I think it would be OK to list all the ucodeX.fw files, but listing all
>> these initvals files seems overkill to me.
>> If you still need all initval filenames, you could theoretically ask
>> b43-fwcutter.
>> That would just need a new fwcutter commandline option, as far as I
>> can see.
>>
>> As you can see, we currently only export the b43 specific firmware ID
>> in MODULE_FIRMWARE().
>> That is a unique identifier for a whole set of firmware files.
>> b43-fwcutter also
>> knows about that firmware ID.
>>
>> (While we're at it, I think the FW-id that b43 announces should be
>> updated. Because
>> I think the firmware with the currently announced ID does not support
>> all LP devices.)
>>
>
> How about the attached version that only includes the ucode files ?
This one looks good to me. Would you also like to do one for b43legacy with
ucode2.fw and ucode4.fw, or should I do it?
Larry
next prev parent reply other threads:[~2010-01-09 3:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-07 18:35 [PATCH] b43: Declare all possible firmware files Tim Gardner
2010-01-07 19:05 ` Larry Finger
2010-01-07 19:19 ` Tim Gardner
2010-01-07 19:31 ` Larry Finger
2010-01-07 19:43 ` Tim Gardner
2010-01-08 17:32 ` Martin Pitt
2010-01-08 19:05 ` Michael Buesch
2010-01-09 1:19 ` Tim Gardner
2010-01-09 3:47 ` Larry Finger [this message]
2010-01-12 10:08 ` Tim Gardner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B47FC42.2050502@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=martin.pitt@ubuntu.com \
--cc=mb@bu3sch.de \
--cc=stefano.brivio@polimi.it \
--cc=tim.gardner@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).