From: Larry Finger <Larry.Finger@lwfinger.net>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"John W. Linville" <linville@tuxdriver.com>,
"bcm43xx-dev@lists.berlios.de" <bcm43xx-dev@lists.berlios.de>
Subject: Re: [PATCH 3/3] b43: N-PHY: add RX IQ calculation for rev < 3
Date: Wed, 13 Jan 2010 07:31:37 -0600 [thread overview]
Message-ID: <4B4DCB39.7030801@lwfinger.net> (raw)
In-Reply-To: <op.u6fp66hl9lhzdc@linux-g0th.site>
On 01/12/2010 01:38 PM, Rafał Miłecki wrote:
>
> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
> ---
>
> Uh, bigger one. This patch causes false warning:
> drivers/net/wireless/b43/phy_n.c: In function ‘b43_nphy_rev2_cal_rx_iq’:
> drivers/net/wireless/b43/phy_n.c:627: warning: large integer implicitly truncated to unsigned type
>
> That's for:
> b43_phy_maskset(dev, B43_NPHY_RFSEQCA, ~B43_NPHY_RFSEQCA_RXDIS, ((1 - i) << B43_NPHY_RFSEQCA_RXDIS_SHIFT));
>
> It's inside loop i=0,1. I tried casting i on (u8) but this didn't help. Can we leave this? Or can sb share some trick to avoid this warning?
It is ~B43_NPHY_RFSEQCA_RXDIS, not i, that causes the warning. Change the
statement to
b43_phy_maskset(dev, B43_NPHY_RFSEQCA, (u16)(~B43_NPHY_RFSEQCA_RXDIS),
((1 - i) << B43_NPHY_RFSEQCA_RXDIS_SHIFT));
Larry
next prev parent reply other threads:[~2010-01-13 13:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-12 19:38 [PATCH 3/3] b43: N-PHY: add RX IQ calculation for rev < 3 Rafał Miłecki
2010-01-12 22:19 ` Michael Buesch
2010-01-13 13:31 ` Larry Finger [this message]
2010-01-13 13:38 ` Rafał Miłecki
2010-01-13 14:26 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4DCB39.7030801@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).