linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andriy Tkachuk <andriy.v.tkachuk@globallogic.com>
To: "Luis R. Rodriguez" <mcgrof@gmail.com>
Cc: linux-wireless@vger.kernel.org,
	"John W. Linville" <linville@tuxdriver.com>
Subject: Re: Account HT Control field also in Data frame hdrlen according to 802.11n-2009
Date: Wed, 20 Jan 2010 11:24:17 +0200	[thread overview]
Message-ID: <4B56CBC1.2040406@globallogic.com> (raw)
In-Reply-To: <43e72e891001190949u717da5f6maae6a2ca81f3101f@mail.gmail.com>

On 2010-01-19 19:49, Luis R. Rodriguez wrote:
> The commit log entry is empty.

Sorry, I thought it will be obvious from the $subj

> Can you describe what this fixes
> verbally and if its a critical fix or not, if it is, its important to
> know whether or not to propagate this to stable,

I would say it is rather feature then a fix. It just makes
ieee80211_hdrlen() to account new HT Control field in 802.11 header of
data frames introduced by IEEE 802.11n-2009 standard. That's it.

>  so please explain its
> impact and what the behavior was before this.
>   

According to 802.11n-2009 standard HT Control field is present in data
frames when both following items are true:

   1. It is QoS data frame.
   2. Order bit is 1 in Frame Control field.

The change might be totally compatible with legacy non-11n aware frames,
because 802.11-2007 standard states that for all QoS frames (i.e.
non-11n frames) Order bit must be set to zero.

> Also please prefix your e-mails with [PATCH].
>   

Sorry, just forgot to do this. Hope, next time it will be better. :)

Thanks a lot for attention!

    Andriy

      parent reply	other threads:[~2010-01-20  9:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-18 14:04 Account HT Control field also in Data frame hdrlen according to 802.11n-2009 Andriy Tkachuk
2010-01-18 22:03 ` Benoit PAPILLAULT
2010-01-19 17:49 ` Luis R. Rodriguez
2010-01-20  7:39   ` Holger Schurig
2010-01-20  9:24   ` Andriy Tkachuk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B56CBC1.2040406@globallogic.com \
    --to=andriy.v.tkachuk@globallogic.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=mcgrof@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).