From: Larry Finger <Larry.Finger@lwfinger.net>
To: Michael Buesch <mb@bu3sch.de>
Cc: Johannes Berg <johannes@sipsolutions.net>,
kecsa@kutfo.hit.bme.hu, linux-wireless@vger.kernel.org
Subject: Re: hwtkip hangs on b43
Date: Sat, 23 Jan 2010 12:34:19 -0600 [thread overview]
Message-ID: <4B5B412B.7080502@lwfinger.net> (raw)
In-Reply-To: <201001231919.32466.mb@bu3sch.de>
On 01/23/2010 12:19 PM, Michael Buesch wrote:
> On Saturday 23 January 2010 18:47:42 Johannes Berg wrote:
>>
>> I think this might be because update_tkip_key is called from within the
>> RX path, so it's probably not even safe to use mutexes to start with?
>
> Well, if mac80211 does a callback into the driver on behalf of a driver call,
> that is broken design. It would break for all locks, not just mutexes.
> We should probably switch back to ieee80211_rx_irqsafe to workaround these
> circular locking problems.
Michael, I'll let you fix this. I do confirm that the mutex is locked when the
update_tkip_key callback is invoked.
Was this problem introduced with the switch to interrupt threads? If so, then
the fix needs to be applied to 2.6.32 and 2.6.33.
Larry
next prev parent reply other threads:[~2010-01-23 18:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-23 8:46 hwtkip hangs on b43 kecsa
2010-01-23 17:20 ` Larry Finger
2010-01-23 17:47 ` Johannes Berg
2010-01-23 18:19 ` Michael Buesch
2010-01-23 18:34 ` Larry Finger [this message]
2010-01-23 18:47 ` Michael Buesch
2010-01-23 18:48 ` Johannes Berg
2010-01-23 18:53 ` Johannes Berg
2010-01-23 19:00 ` Michael Buesch
2010-01-23 19:31 ` Larry Finger
2010-01-23 19:38 ` Michael Buesch
2010-01-24 5:58 ` Larry Finger
2010-01-24 11:32 ` Johannes Berg
2010-01-24 11:45 ` Michael Buesch
2010-01-24 11:47 ` Johannes Berg
2010-01-24 11:52 ` Michael Buesch
2010-01-24 12:37 ` Kalle Valo
2010-01-25 10:43 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B5B412B.7080502@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=johannes@sipsolutions.net \
--cc=kecsa@kutfo.hit.bme.hu \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).