From: Felix Fietkau <nbd@openwrt.org>
To: Sujith <Sujith.Manoharan@atheros.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
Luis Rodriguez <Luis.Rodriguez@Atheros.com>,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH] ath9k: fix PAE frame handling
Date: Mon, 01 Feb 2010 06:16:23 +0100 [thread overview]
Message-ID: <4B6663A7.3070608@openwrt.org> (raw)
In-Reply-To: <19302.24837.154697.822430@gargle.gargle.HOWL>
On 2010-02-01 6:05 AM, Sujith wrote:
> Felix Fietkau wrote:
>> ath9k's tx handling code contains a special case for PAE frames, which
>> looks like it was intended to be improving reliability by excluding
>> them from aggregates.
>> What it actually did is the opposite: By assigning a faulty sequence
>> number, yet still keeping it as a qos-frame, it caused bogus packet
>> reordering, which broke WPA rekeying.
>> The special case handling is completely unnecessary, so this patch
>> removes it.
>
> Sending PAE frames as part of an aggregate broke crypto with several APs.
> Assigning the correct seq. number should work, no ?
>
> Something like the patch below. Can you check if it fixes your issue ?
> Though, removing the seq. number mess in the driver would be great. :D
Works for me. Tested it with a really short rekey interval, and I'm
getting no packet loss or connection interruption.
- Felix
next prev parent reply other threads:[~2010-02-01 5:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-31 21:33 [PATCH] ath9k: fix PAE frame handling Felix Fietkau
2010-02-01 5:05 ` Sujith
2010-02-01 5:16 ` Felix Fietkau [this message]
2010-02-04 10:07 ` Kalle Valo
2010-02-09 4:40 ` Sujith
2010-02-08 21:39 ` John W. Linville
2010-02-09 4:35 ` Sujith
2010-02-16 19:42 ` Felix Fietkau
2010-02-16 19:50 ` Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B6663A7.3070608@openwrt.org \
--to=nbd@openwrt.org \
--cc=Luis.Rodriguez@Atheros.com \
--cc=Sujith.Manoharan@atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).