From: Gertjan van Wingerde <gwingerde@gmail.com>
To: Ivo van Doorn <ivdoorn@gmail.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, users@rt2x00.serialmonkey.com
Subject: Re: [PATCH 2/3] rt2x00: Reorganize RT chipset setting for PCI/SOC devices.
Date: Sun, 14 Feb 2010 10:21:13 +0100 [thread overview]
Message-ID: <4B77C089.9090403@gmail.com> (raw)
In-Reply-To: <201002140215.14535.IvDoorn@gmail.com>
On 02/14/10 02:15, Ivo van Doorn wrote:
> Hi,
>
>> --- a/drivers/net/wireless/rt2x00/rt2800lib.c
>> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
>> @@ -40,6 +40,9 @@
>> #if defined(CONFIG_RT2X00_LIB_USB) || defined(CONFIG_RT2X00_LIB_USB_MODULE)
>> #include "rt2x00usb.h"
>> #endif
>> +#if defined(CONFIG_RT2X00_LIB_PCI) || defined(CONFIG_RT2X00_LIB_PCI_MODULE)
>> +#include "rt2x00pci.h"
>> +#endif
>
> this is very ugly, but apparently it is unavoidable to make rt2800lib free from
> PCI and USB specific code... :(
>
Actually, this is a temporary situation, and this chunk can be removed again after
patch 3 of the series has been applied.
I'll create a cleanup patch to exactly to that.
With respect to the USB specific code, I have to look at if there is a way to
resolve that, as the USB specific code is only there in 1 place. Maybe a call-back
function to the bus-specific rt2800 drivers could help here.
---
Gertjan.
next prev parent reply other threads:[~2010-02-14 9:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-13 19:55 [PATCH 0/3] rt2x00: rt2800 detection improvements Gertjan van Wingerde
2010-02-13 19:55 ` [PATCH 1/3] rt2x00: Introduce SoC interface type Gertjan van Wingerde
2010-02-13 19:55 ` [PATCH 2/3] rt2x00: Reorganize RT chipset setting for PCI/SOC devices Gertjan van Wingerde
2010-02-13 19:55 ` [PATCH 3/3] rt2x00: rework RT chipset and revision determination for PCI an SOC devices Gertjan van Wingerde
2010-02-14 1:15 ` Ivo van Doorn
2010-02-14 1:15 ` [PATCH 2/3] rt2x00: Reorganize RT chipset setting for PCI/SOC devices Ivo van Doorn
2010-02-14 1:36 ` Pavel Roskin
2010-02-14 9:21 ` Gertjan van Wingerde [this message]
2010-02-14 1:15 ` [PATCH 1/3] rt2x00: Introduce SoC interface type Ivo van Doorn
2010-02-14 1:37 ` [PATCH 0/3] rt2x00: rt2800 detection improvements Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B77C089.9090403@gmail.com \
--to=gwingerde@gmail.com \
--cc=ivdoorn@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=users@rt2x00.serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).