From: Larry Finger <Larry.Finger@lwfinger.net>
To: Frederic Leroy <fredo@starox.org>
Cc: linux-wireless@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: [RFC PATCH] staging: rtl8192su: remove dead code
Date: Wed, 17 Feb 2010 10:51:14 -0600 [thread overview]
Message-ID: <4B7C1E82.4030005@lwfinger.net> (raw)
In-Reply-To: <20100217091920.083a3dd3@houba>
On 02/17/2010 02:19 AM, Frederic Leroy wrote:
> Hello,
>
> This patch removes some dead code in rtl8192su driver in staging against linux-2.6-stable tree.
> Should I split it into smaller chunk ?
> As it is in staging, should I post it to linux-kernel@vger.kernel.org ?
At 1400+ lines, the patch is a little large. I would recommend that you separate
out the fixes for "ifdef RTL8190P" and "ifdef RTL8190U" into one patch, and the
changes for "ifdef TO_DO_LIST" into a couple of patches. That should get the
line count to below 500 in the individual patches.
These patches should be sent to GregKH with Cc: to linux-wireless and
linux-kernel@vger.kernel.org.
I'm not sure how you sent this patch, but when I extracted it from my mailer
(Thunderbird 3.0.1), it ended up with no line breaks. To get it as a usable
file, I had to copy and paste. Coordinators get rather testy when presented with
such patches.
Larry
next prev parent reply other threads:[~2010-02-17 16:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-17 8:19 [RFC PATCH] staging: rtl8192su: remove dead code Frederic Leroy
2010-02-17 16:51 ` Larry Finger [this message]
2010-02-18 16:06 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B7C1E82.4030005@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=fredo@starox.org \
--cc=gregkh@suse.de \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).