From: Larry Finger <Larry.Finger@lwfinger.net>
To: okias <d.okias@gmail.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
herton@mandriva.com.br, htl10@users.sourceforge.net
Subject: Re: [PATCH] rtl818x: small cleanup
Date: Wed, 17 Feb 2010 11:15:50 -0600 [thread overview]
Message-ID: <4B7C2446.6030507@lwfinger.net> (raw)
In-Reply-To: <c2673ca61002170905g788ce856uc82adc490c2328be@mail.gmail.com>
On 02/17/2010 11:05 AM, okias wrote:
> -2 lines...
Your patch is fine, but there are problems in the presentation. For review
purposes, it should be in-line, not as an attachment. The second problem is that
the patch is for rtl8187, not for wireless/rtl818x. There are 2 drivers, soon to
be more, in that particular directory.
Larry
next prev parent reply other threads:[~2010-02-17 17:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-17 17:05 [PATCH] rtl818x: small cleanup okias
2010-02-17 17:15 ` Larry Finger [this message]
2010-02-17 17:16 ` Hin-Tak Leung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B7C2446.6030507@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=d.okias@gmail.com \
--cc=herton@mandriva.com.br \
--cc=htl10@users.sourceforge.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox