From: Larry Finger <Larry.Finger@lwfinger.net>
To: okias <d.okias@gmail.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
herton@mandriva.com.br, htl10@users.sourceforge.net
Subject: Re: [PATCH] v2: rtl8187: micro cleanup
Date: Wed, 17 Feb 2010 12:30:33 -0600 [thread overview]
Message-ID: <4B7C35C9.30607@lwfinger.net> (raw)
In-Reply-To: <c2673ca61002171015j375922c0y4c7f61c3d3322bab@mail.gmail.com>
On 02/17/2010 12:15 PM, okias wrote:
>>From 3f02b3ec0c3e6d7fa0599de12af0b76150854b94 Mon Sep 17 00:00:00 2001
> From: David Heidelberger <d.okias@gmail.com>
> Date: Wed, 17 Feb 2010 19:13:46 +0100
> Subject: [PATCH] rtl8187: micro cleanup
>
> ---
> drivers/net/wireless/rtl818x/rtl8187_dev.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/rtl818x/rtl8187_dev.c
> b/drivers/net/wireless/rtl818x/rtl8187_dev.c
> index 7ba3052..2fe0c84 100644
> --- a/drivers/net/wireless/rtl818x/rtl8187_dev.c
> +++ b/drivers/net/wireless/rtl818x/rtl8187_dev.c
> @@ -1175,8 +1175,6 @@ static void rtl8187_bss_info_changed(struct
> ieee80211_hw *dev,
>
> if (priv->is_rtl8187b)
> reg = RTL818X_MSR_ENEDCA;
> - else
> - reg = 0;
>
> if (is_valid_ether_addr(info->bssid)) {
> reg |= RTL818X_MSR_INFRA;
Did you forget the initialization to 0 when you declare the variable? It was in
the first version. This change will cause the RTL8187L to fail.
Larry
next prev parent reply other threads:[~2010-02-17 18:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-17 18:15 [PATCH] v2: rtl8187: micro cleanup okias
2010-02-17 18:30 ` Larry Finger [this message]
2010-02-17 18:34 ` okias
2010-02-17 18:36 ` Johannes Berg
2010-02-17 18:38 ` okias
2010-02-17 18:58 ` Pavel Roskin
2010-02-17 19:04 ` okias
2010-02-17 19:13 ` Sedat Dilek
2010-02-17 21:14 ` Hin-Tak Leung
2010-02-17 22:44 ` Pavel Roskin
2010-02-17 20:47 ` Hin-Tak Leung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B7C35C9.30607@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=d.okias@gmail.com \
--cc=herton@mandriva.com.br \
--cc=htl10@users.sourceforge.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).