From: Larry Finger <Larry.Finger@lwfinger.net>
To: Kalle Valo <kalle.valo@iki.fi>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Frederic Leroy <fredo@starox.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: [PATCH] staging: rtl8192su: fix compile error from wireless-testing commit
Date: Sat, 20 Feb 2010 12:59:25 -0600 [thread overview]
Message-ID: <4B80310D.2060302@lwfinger.net> (raw)
In-Reply-To: <871vgfhi7n.fsf@purkki.valot.fi>
On 02/20/2010 12:31 PM, Kalle Valo wrote:
> "John W. Linville" <linville@tuxdriver.com> writes:
>
>> Since I've got the 'offending' commit in my tree, I'll carry this
>> staging fixup as well...
>
> And I was the one who broke this, sorry. What's the general rule for
> this, should I also start compile testing staging drivers when
> changing something?
As someone else that was hit by this problem, I think that is a good idea. I
realize that staging drivers are a special case, but it is likely easier for the
person changing the ABI to fix any breakage. In addition, if the fixes are
entered at the same time as the original change, there will not be any build
breakage during bisection, and any questions of which coordinator to use will be
avoided.
Larry
next prev parent reply other threads:[~2010-02-20 18:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-17 23:25 [PATCH] staging: rtl8192su: fix compile error from wireless-testing commit Frederic Leroy
2010-02-19 19:52 ` John W. Linville
2010-02-20 18:31 ` Kalle Valo
2010-02-20 18:59 ` Larry Finger [this message]
2010-02-20 20:46 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B80310D.2060302@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=fredo@starox.org \
--cc=gregkh@suse.de \
--cc=kalle.valo@iki.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).