Re: [PATCH] mac80211: fix rates setup on IBSS merge

[Benoit PAPILLAULT <benoit.papillault@free.fr>]

Luis R. Rodriguez a écrit :
> On Tue, Feb 23, 2010 at 1:51 AM, Bruno Randolf <br1@einfach.org> wrote:
>   
>> when an IBSS merge happened, the supported rates for the newly added station
>> were left empty, causing the rate control module to be initialized with only
>> the basic rates.
>>
>> also the section of the ibss code which deals with updating supported rates for
>> an already existing station fails to inform the rate control module about the
>> new rates. as i don't know how to fix this (minstrel does not have an update
>> function), i have just added a comment for now.
>>
>> Signed-off-by: Bruno Randolf <br1@einfach.org>
>>     
>
> This seems like a stable fix, if it applies can you please resend with a
>
> Cc: stable@kernel.org
>
> on the commit log entry right below your own SOB.
>
>   Luis
>   
Hi Bruno,

I think the root cause is that IBSS neighbor entries are added whenever 
we received any packet from a neighbor. However, the supported rates are 
only available in the beacon/probe responses. I think one fix is to only 
add IBSS neighbors on beacon/probe response reception (and moreover, 
beacon/probe responses contains the timestamp that is needed for IBSS 
merge).

Basically, I removed the call to ieee80211_ibss_add_sta in 
net/mac80211/rx.c.

Can you try that and tell me about the result?

In fact, I did this change to have HT rates in IBSS mode (but I'm still 
missing some stuff).

Regards,
Benoit