From: Alban Browaeys <prahal@yahoo.com>
To: Pavel Roskin <proski@gnu.org>
Cc: John Linville <linville@tuxdriver.com>,
rt2x00 Users List <users@rt2x00.serialmonkey.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
Ivo van Doorn <ivdoorn@gmail.com>
Subject: Re: [PATCH 2/2] rt2x00 : fix txdone implementation
Date: Thu, 25 Feb 2010 14:54:11 +0100 [thread overview]
Message-ID: <4B868103.6030704@yahoo.com> (raw)
In-Reply-To: <20100224205814.974teh5rf48w4g8o-cebfxv@webmail.spamcop.net>
On 25/02/2010 02:58, Pavel Roskin wrote:
> Quoting Alban Browaeys <prahal@yahoo.com>:
>
>> Properly move to the headroom position in dma mapped skb. The hw extra
>> headroom is now taken into account.
>>
>> Signed-off-by: Alban Browaeys <prahal@yahoo.com>
> ...
>> - rt2x00_set_field32(&word, TXD_W2_SD_PTR1,
>> - skbdesc->skb_dma + rt2x00dev->ops->extra_tx_headroom);
>> + rt2x00_set_field32(&word, TXD_W2_SD_PTR1, skbdesc->skb_dma
>> + + rt2x00dev->ops->extra_tx_headroom);
>
> I think it's just a formatting change. I would not mix formatting
> changes with the real fixes. I can understand reformatting code that
> is also modified in some other way, but that's even a separate function.
>
Thank you. There was a real change (I did not meant for to reformat this
line) but it got merged and I did not saw it.
I sent a new version of the patch without the first now uneeded change.
Best regards,
Alban
next prev parent reply other threads:[~2010-02-25 13:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-25 0:54 [PATCH 2/2] rt2x00 : fix txdone implementation Alban Browaeys
2010-02-25 1:58 ` Pavel Roskin
2010-02-25 13:54 ` Alban Browaeys [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-02-25 13:52 Alban Browaeys
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B868103.6030704@yahoo.com \
--to=prahal@yahoo.com \
--cc=ivdoorn@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=proski@gnu.org \
--cc=users@rt2x00.serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).