* [PATCH 2/2] rt2x00 : fix txdone implementation
@ 2010-02-25 13:52 Alban Browaeys
2010-02-25 17:23 ` [rt2x00-users] " Gertjan van Wingerde
0 siblings, 1 reply; 2+ messages in thread
From: Alban Browaeys @ 2010-02-25 13:52 UTC (permalink / raw)
To: John Linville
Cc: rt2x00 Users List, Pavel Roskin, linux-wireless, Ivo van Doorn
Properly move to the headroom position in dma mapped skb. The hw extra
headroom is now taken into account.
Signed-off-by: Alban Browaeys <prahal@yahoo.com>
---
drivers/net/wireless/rt2x00/rt2800pci.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/rt2x00/rt2800pci.c b/drivers/net/wireless/rt2x00/rt2800pci.c
index 46b06af..fbeff5c 100644
--- a/drivers/net/wireless/rt2x00/rt2800pci.c
+++ b/drivers/net/wireless/rt2x00/rt2800pci.c
@@ -966,7 +966,7 @@ static void rt2800pci_txdone(struct rt2x00_dev *rt2x00dev)
/* Check if we got a match by looking at WCID/ACK/PID
* fields */
txwi = (__le32 *)(entry->skb->data -
- rt2x00dev->hw->extra_tx_headroom);
+ rt2x00dev->ops->extra_tx_headroom);
rt2x00_desc_read(txwi, 1, &word);
tx_wcid = rt2x00_get_field32(word, TXWI_W1_WIRELESS_CLI_ID);
--
1.7.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [rt2x00-users] [PATCH 2/2] rt2x00 : fix txdone implementation
2010-02-25 13:52 [PATCH 2/2] rt2x00 : fix txdone implementation Alban Browaeys
@ 2010-02-25 17:23 ` Gertjan van Wingerde
0 siblings, 0 replies; 2+ messages in thread
From: Gertjan van Wingerde @ 2010-02-25 17:23 UTC (permalink / raw)
To: prahal, rt2x00 Users List; +Cc: John Linville, Pavel Roskin, linux-wireless
On 02/25/10 14:52, Alban Browaeys wrote:
> Properly move to the headroom position in dma mapped skb. The hw extra
> headroom is now taken into account.
>
> Signed-off-by: Alban Browaeys <prahal@yahoo.com>
> ---
> drivers/net/wireless/rt2x00/rt2800pci.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2800pci.c
> b/drivers/net/wireless/rt2x00/rt2800pci.c
> index 46b06af..fbeff5c 100644
> --- a/drivers/net/wireless/rt2x00/rt2800pci.c
> +++ b/drivers/net/wireless/rt2x00/rt2800pci.c
> @@ -966,7 +966,7 @@ static void rt2800pci_txdone(struct rt2x00_dev
> *rt2x00dev)
> /* Check if we got a match by looking at WCID/ACK/PID
> * fields */
> txwi = (__le32 *)(entry->skb->data -
> - rt2x00dev->hw->extra_tx_headroom);
> + rt2x00dev->ops->extra_tx_headroom);
>
> rt2x00_desc_read(txwi, 1, &word);
> tx_wcid = rt2x00_get_field32(word, TXWI_W1_WIRELESS_CLI_ID);
This seems to be fixing an issue with your first patch. Please fold this fix into the first
patch and submit a single "working" patch.
---
Gertjan.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-02-25 17:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-25 13:52 [PATCH 2/2] rt2x00 : fix txdone implementation Alban Browaeys
2010-02-25 17:23 ` [rt2x00-users] " Gertjan van Wingerde
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).