linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alban Browaeys <prahal@yahoo.com>
To: prahal@yahoo.com
Cc: John Linville <linville@tuxdriver.com>,
	Josef Bacik <josef@redhat.com>, Ivo van Doorn <ivdoorn@gmail.com>,
	Pavel Roskin <proski@gnu.org>,
	rt2x00 Users List <users@rt2x00.serialmonkey.com>,
	Gertjan van Wingerde <gwingerde@gmail.com>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] rt2x00: Fix TX status reporting for rt2800pci.
Date: Fri, 26 Feb 2010 15:38:28 +0100	[thread overview]
Message-ID: <4B87DCE4.3090708@yahoo.com> (raw)
In-Reply-To: <4B87D9FF.5080105@yahoo.com>

On 26/02/2010 15:26, Alban Browaeys wrote:
> After testing, we found that TX_STA_FIFO_MCS is the last MCS value
> tried. If the transmission failed, 8 frames have been transmitted. If the
> transmission succeed, we can easily compute the number of retry.  This 
> patch fix
> the way status is reported to mac80211 rate control. It has 2 bugs :
>
> 1. mcs can contain the short preamble flag and it will lead to wrong
> computations.
>
> 2. minstrel nearly always say that 54 Mbits is the best rate, even if 
> we are
> very far from the AP
>
> TX_DONE_FALLBACK flag meaning has been changed : it means that a
> fallback rate table is used by the hardware.
>
> Signed-off-by: Benoit Papillault <benoit.papillault@free.fr>

This patch fixes the probe timeout after less than 2 minutes.
I probably should have resend the two patches (tx done hw implementation 
and this one). Just thought about it.
As it applies above the tx done implementation. I did not make one that 
applies above the software only implementation as it is broken since 
entry index was replaced by key index in rt2800pci write tx desc (as 
Wireless Cli Id).



  reply	other threads:[~2010-02-26 14:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-26 14:26 [PATCH] rt2x00: Fix TX status reporting for rt2800pci Alban Browaeys
2010-02-26 14:38 ` Alban Browaeys [this message]
2010-02-26 22:56 ` Gertjan van Wingerde
2010-03-01  7:34 ` Ivo van Doorn
  -- strict thread matches above, loose matches on Subject: below --
2010-02-28 16:14 Alban Browaeys
2010-02-28 19:19 ` Gertjan van Wingerde
2010-03-01  7:34 ` Ivo van Doorn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B87DCE4.3090708@yahoo.com \
    --to=prahal@yahoo.com \
    --cc=gwingerde@gmail.com \
    --cc=ivdoorn@gmail.com \
    --cc=josef@redhat.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=proski@gnu.org \
    --cc=users@rt2x00.serialmonkey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).