* [PATCH] rt2x00: fix rt2800pci compilation with SoC
@ 2010-03-02 15:34 Helmut Schaa
2010-03-02 19:11 ` Gertjan van Wingerde
0 siblings, 1 reply; 5+ messages in thread
From: Helmut Schaa @ 2010-03-02 15:34 UTC (permalink / raw)
To: John Linville; +Cc: linux-wireless, Gertjan van Wingerde, Ivo van Doorn
Compiling rt2800pci with CONFIG_RT2800PCI_SOC fails with "... rt2880pci.c:
error: incompatible type for argument 2 of 'rt2x00soc_probe'".
Fix this by using &rt2800pci_ops instead of rt2800pci_ops.
Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>
---
Just noticed that error while trying to compile rt2800pci for a
Ralink SoC board.
diff --git a/drivers/net/wireless/rt2x00/rt2800pci.c b/drivers/net/wireless/rt2x00/rt2800pci.c
index 0e4c417..f71e83b 100644
--- a/drivers/net/wireless/rt2x00/rt2800pci.c
+++ b/drivers/net/wireless/rt2x00/rt2800pci.c
@@ -1225,7 +1225,7 @@ MODULE_LICENSE("GPL");
#ifdef CONFIG_RT2800PCI_SOC
static int rt2800soc_probe(struct platform_device *pdev)
{
- return rt2x00soc_probe(pdev, rt2800pci_ops);
+ return rt2x00soc_probe(pdev, &rt2800pci_ops);
}
static struct platform_driver rt2800soc_driver = {
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] rt2x00: fix rt2800pci compilation with SoC
2010-03-02 15:34 [PATCH] rt2x00: fix rt2800pci compilation with SoC Helmut Schaa
@ 2010-03-02 19:11 ` Gertjan van Wingerde
2010-03-02 19:45 ` John W. Linville
0 siblings, 1 reply; 5+ messages in thread
From: Gertjan van Wingerde @ 2010-03-02 19:11 UTC (permalink / raw)
To: Helmut Schaa, John Linville; +Cc: linux-wireless, Ivo van Doorn
On 03/02/10 16:34, Helmut Schaa wrote:
> Compiling rt2800pci with CONFIG_RT2800PCI_SOC fails with "... rt2880pci.c:
> error: incompatible type for argument 2 of 'rt2x00soc_probe'".
>
> Fix this by using &rt2800pci_ops instead of rt2800pci_ops.
>
> Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>
> ---
Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>
John, this is probably one that should go to wireless-2.6.
---
Gertjan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] rt2x00: fix rt2800pci compilation with SoC
2010-03-02 19:11 ` Gertjan van Wingerde
@ 2010-03-02 19:45 ` John W. Linville
2010-03-02 20:03 ` Helmut Schaa
2010-03-02 20:31 ` Gertjan van Wingerde
0 siblings, 2 replies; 5+ messages in thread
From: John W. Linville @ 2010-03-02 19:45 UTC (permalink / raw)
To: Gertjan van Wingerde; +Cc: Helmut Schaa, linux-wireless, Ivo van Doorn
On Tue, Mar 02, 2010 at 08:11:08PM +0100, Gertjan van Wingerde wrote:
> On 03/02/10 16:34, Helmut Schaa wrote:
> > Compiling rt2800pci with CONFIG_RT2800PCI_SOC fails with "... rt2880pci.c:
> > error: incompatible type for argument 2 of 'rt2x00soc_probe'".
> >
> > Fix this by using &rt2800pci_ops instead of rt2800pci_ops.
> >
> > Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>
> > ---
>
> Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>
>
> John, this is probably one that should go to wireless-2.6.
I agree, which is why I fixed the whitespace damage and applied it...grrr...
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] rt2x00: fix rt2800pci compilation with SoC
2010-03-02 19:45 ` John W. Linville
@ 2010-03-02 20:03 ` Helmut Schaa
2010-03-02 20:31 ` Gertjan van Wingerde
1 sibling, 0 replies; 5+ messages in thread
From: Helmut Schaa @ 2010-03-02 20:03 UTC (permalink / raw)
To: John W. Linville; +Cc: Gertjan van Wingerde, linux-wireless, Ivo van Doorn
Am Dienstag 02 März 2010 schrieb John W. Linville:
> On Tue, Mar 02, 2010 at 08:11:08PM +0100, Gertjan van Wingerde wrote:
> > On 03/02/10 16:34, Helmut Schaa wrote:
> > > Compiling rt2800pci with CONFIG_RT2800PCI_SOC fails with "... rt2880pci.c:
> > > error: incompatible type for argument 2 of 'rt2x00soc_probe'".
> > >
> > > Fix this by using &rt2800pci_ops instead of rt2800pci_ops.
> > >
> > > Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>
> > > ---
> >
> > Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>
> >
> > John, this is probably one that should go to wireless-2.6.
>
> I agree, which is why I fixed the whitespace damage and applied it...grrr...
Oops, sorry John.
Thank you,
Helmut
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] rt2x00: fix rt2800pci compilation with SoC
2010-03-02 19:45 ` John W. Linville
2010-03-02 20:03 ` Helmut Schaa
@ 2010-03-02 20:31 ` Gertjan van Wingerde
1 sibling, 0 replies; 5+ messages in thread
From: Gertjan van Wingerde @ 2010-03-02 20:31 UTC (permalink / raw)
To: John W. Linville; +Cc: Helmut Schaa, linux-wireless, Ivo van Doorn
On 03/02/10 20:45, John W. Linville wrote:
> On Tue, Mar 02, 2010 at 08:11:08PM +0100, Gertjan van Wingerde wrote:
>> On 03/02/10 16:34, Helmut Schaa wrote:
>>> Compiling rt2800pci with CONFIG_RT2800PCI_SOC fails with "... rt2880pci.c:
>>> error: incompatible type for argument 2 of 'rt2x00soc_probe'".
>>>
>>> Fix this by using &rt2800pci_ops instead of rt2800pci_ops.
>>>
>>> Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>
>>> ---
>>
>> Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>
>>
>> John, this is probably one that should go to wireless-2.6.
>
> I agree, which is why I fixed the whitespace damage and applied it...grrr...
OK. Thanks for that.
---
Gertjan.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-03-02 20:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-02 15:34 [PATCH] rt2x00: fix rt2800pci compilation with SoC Helmut Schaa
2010-03-02 19:11 ` Gertjan van Wingerde
2010-03-02 19:45 ` John W. Linville
2010-03-02 20:03 ` Helmut Schaa
2010-03-02 20:31 ` Gertjan van Wingerde
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).