From: Felix Fietkau <nbd@openwrt.org>
To: "Luis R. Rodriguez" <lrodriguez@atheros.com>
Cc: "linville@tuxdriver.com" <linville@tuxdriver.com>,
Vivek Natarajan <Vivek.Natarajan@atheros.com>,
Sujith Manoharan <Sujith.Manoharan@atheros.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v3 00/12] ath9k_hw: complete support for AR9271
Date: Tue, 16 Mar 2010 01:05:18 +0100 [thread overview]
Message-ID: <4B9ECB3E.3010802@openwrt.org> (raw)
In-Reply-To: <43e72e891003151655i7dc051d0lc1da26267e9c706@mail.gmail.com>
On 2010-03-16 12:55 AM, Luis R. Rodriguez wrote:
> On Mon, Mar 15, 2010 at 4:52 PM, Felix Fietkau <nbd@openwrt.org> wrote:
>> On 2010-03-16 12:49 AM, Luis R. Rodriguez wrote:
>>> diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c
>>> index 00570fb..867cfaf 100644
>>> --- a/drivers/net/wireless/ath/ath9k/hw.c
>>> +++ b/drivers/net/wireless/ath/ath9k/hw.c
>>> @@ -807,6 +804,10 @@ void ath9k_hw_init_global_settings(struct ath_hw *ah)
>>> acktimeout += 64 - sifstime - ah->slottime;
>>>
>>> ath9k_hw_setslottime(ah, slottime);
>>> +
>>> + if (AR_SREV_9271(ah))
>>> + return;
>>> +
>>> ath9k_hw_set_ack_timeout(ah, acktimeout);
>>> ath9k_hw_set_cts_timeout(ah, acktimeout);
>>> if (ah->globaltxtimeout != (u32) -1)
>>
>> Why leave out the ACK/CTS timeout setting? How does the hw handle ACK
>> and CTS timeouts?
>
> Right, so that's why I originally removed this hunk completely, I was
> under the impression you latest fix would have addressed any issues
> but it does not, we get association time outs. I think we'll have to
> review this further in order to support coverage class.
Are you sure the slot time was set properly by the callback? Can you
print out the values that it's setting? The initvals for 9271 don't
really look all that different.
- Felix
next prev parent reply other threads:[~2010-03-16 0:05 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-13 5:46 [PATCH v3 00/12] ath9k_hw: complete support for AR9271 Luis R. Rodriguez
2010-03-13 5:46 ` [PATCH v3 01/12] ath9k_hw: update initialization values " Luis R. Rodriguez
2010-03-13 5:46 ` [PATCH v3 02/12] ath9k_hw: add GPIO setup code " Luis R. Rodriguez
2010-03-13 5:46 ` [PATCH v3 03/12] ath9k_hw: skip chip tests " Luis R. Rodriguez
2010-03-13 5:46 ` [PATCH v3 04/12] ath9k_hw: fix RF analog setup " Luis R. Rodriguez
2010-03-13 6:05 ` Luis R. Rodriguez
2010-03-15 21:35 ` Luis R. Rodriguez
2010-03-13 5:46 ` [PATCH v3 05/12] ath9k_hw: fix TX descriptor " Luis R. Rodriguez
2010-03-13 5:46 ` [PATCH v3 06/12] ath9k_hw: Fix full sleep " Luis R. Rodriguez
2010-03-13 5:46 ` [PATCH v3 07/12] ath9k_hw: fix noisefloor history buffer usage on AR9271 Luis R. Rodriguez
2010-03-13 5:46 ` [PATCH v3 08/12] ath9k_hw: restrict valid nf readings for AR9271 to -114 Luis R. Rodriguez
2010-03-13 5:46 ` [PATCH v3 09/12] ath9k_hw: use the skip count for PA calibration on AR9271 Luis R. Rodriguez
2010-03-13 5:46 ` [PATCH v3 10/12] ath9k_hw: always set the core clock for AR9271 Luis R. Rodriguez
2010-03-13 5:46 ` [PATCH v3 11/12] ath9k_hw: add HTC init hardware call for special resets " Luis R. Rodriguez
2010-03-13 5:46 ` [PATCH v3 12/12] ath9k_hw: fix hardware deinit Luis R. Rodriguez
2010-03-13 5:56 ` [PATCH v3 00/12] ath9k_hw: complete support for AR9271 Luis R. Rodriguez
2010-03-15 21:43 ` Luis R. Rodriguez
2010-03-15 23:25 ` Luis R. Rodriguez
2010-03-15 23:49 ` Luis R. Rodriguez
2010-03-15 23:51 ` Luis R. Rodriguez
2010-03-15 23:52 ` Felix Fietkau
2010-03-15 23:55 ` Luis R. Rodriguez
2010-03-15 23:55 ` Luis R. Rodriguez
2010-03-16 0:05 ` Felix Fietkau [this message]
2010-03-16 0:09 ` Luis R. Rodriguez
2010-03-16 0:38 ` Luis R. Rodriguez
2010-03-16 3:22 ` Sujith
2010-03-16 3:51 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B9ECB3E.3010802@openwrt.org \
--to=nbd@openwrt.org \
--cc=Sujith.Manoharan@atheros.com \
--cc=Vivek.Natarajan@atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).