From: Gertjan van Wingerde <gwingerde@gmail.com>
To: Ivo van Doorn <ivdoorn@gmail.com>
Cc: users@rt2x00.serialmonkey.com,
Ondrej Zary <linux@rainbow-software.org>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [rt2x00-users] [PATCH] rt2500usb: fix powersaving random failures
Date: Tue, 30 Mar 2010 07:11:50 +0200 [thread overview]
Message-ID: <4BB18816.4040603@gmail.com> (raw)
In-Reply-To: <201003292300.12013.IvDoorn@gmail.com>
On 03/29/10 23:00, Ivo van Doorn wrote:
> On Monday 29 March 2010, Gertjan van Wingerde wrote:
>> On 03/29/10 09:56, Ondrej Zary wrote:
>>> This patch seems to fix random powersaving failure where the device state is
>>> stuck at 1 (STATE_SLEEP) and does not change to 3 (STATE_AWAKE), resulting in
>>> to associate and these error messages:
>>> phy0 -> rt2500usb_set_device_state: Error - Device failed to enter state 3 (-16).
>>> No probe response from AP xx:xx:xx:xx:xx:xx after 500ms, disconnecting.
>>>
>>> Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
>>
>> Thanks. This looks good, but I'll rehash it against the latest state of affairs of rt2x00,
>> so that the disabling of powersaving is undone at the same time.
>>
>> John, I'll send you the rehashed patch tomorrow.
>
> Is this change interesting for the other drivers as well?
> Anyway, this one gets my Ack:
>
> Acked-By: Ivo van Doorn <IvDoorn@gmail.com>
Correct. That is the other reason to rehash. At least rt2400pci and rt2500pci can use
the same change.
>
>> ---
>> Gertjan.
>>
>>>
>>> --- linux-2.6.34-rc2-orig/drivers/net/wireless/rt2x00/rt2500usb.c 2010-03-20 02:17:57.000000000 +0100
>>> +++ linux-2.6.34-rc2/drivers/net/wireless/rt2x00/rt2500usb.c 2010-03-29 09:38:02.000000000 +0200
>>> @@ -648,6 +648,10 @@
>>>
>>> rt2x00_set_field16(®, MAC_CSR18_AUTO_WAKE, 1);
>>> rt2500usb_register_write(rt2x00dev, MAC_CSR18, reg);
>>> + } else {
>>> + rt2500usb_register_read(rt2x00dev, MAC_CSR18, ®);
>>> + rt2x00_set_field16(®, MAC_CSR18_AUTO_WAKE, 0);
>>> + rt2500usb_register_write(rt2x00dev, MAC_CSR18, reg);
>>> }
>>>
>>> rt2x00dev->ops->lib->set_device_state(rt2x00dev, state);
>>>
>>
>>
>> _______________________________________________
>> users mailing list
>> users@rt2x00.serialmonkey.com
>> http://rt2x00.serialmonkey.com/mailman/listinfo/users_rt2x00.serialmonkey.com
>>
>
>
>
next prev parent reply other threads:[~2010-03-30 5:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-29 7:56 [PATCH] rt2500usb: fix powersaving random failures Ondrej Zary
2010-03-29 19:47 ` Gertjan van Wingerde
2010-03-29 21:00 ` [rt2x00-users] " Ivo van Doorn
2010-03-30 5:11 ` Gertjan van Wingerde [this message]
2010-03-30 6:01 ` Ondrej Zary
2010-03-30 12:33 ` Ondrej Zary
2010-03-30 12:38 ` Ondrej Zary
2010-03-30 12:56 ` Matthijs Kooijman
2010-03-30 20:09 ` [PATCH] [RFC] rt2500pci: fix powersaving Ondrej Zary
2010-03-30 20:32 ` Matthijs Kooijman
2010-03-30 20:38 ` [rt2x00-users] " Gertjan van Wingerde
2010-03-30 21:02 ` Gertjan van Wingerde
2010-03-30 21:35 ` Ondrej Zary
2010-03-30 21:44 ` Gertjan van Wingerde
2010-03-31 17:41 ` Matthijs Kooijman
2010-03-31 18:38 ` Gertjan van Wingerde
2010-03-31 18:46 ` Gertjan van Wingerde
2010-03-31 19:00 ` [rt2x00-users] " Matthijs Kooijman
2010-04-03 14:11 ` Gertjan van Wingerde
2010-04-03 15:28 ` Matthijs Kooijman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BB18816.4040603@gmail.com \
--to=gwingerde@gmail.com \
--cc=ivdoorn@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@rainbow-software.org \
--cc=linville@tuxdriver.com \
--cc=users@rt2x00.serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).