From: Gertjan van Wingerde <gwingerde@gmail.com>
To: Adam Baker <linux@baker-net.org.uk>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/4] rt2x00: Enable powersaving by default again on rt2500usb.
Date: Thu, 01 Apr 2010 00:34:53 +0200 [thread overview]
Message-ID: <4BB3CE0D.1030707@gmail.com> (raw)
In-Reply-To: <loom.20100401T002825-964@post.gmane.org>
On 04/01/10 00:29, Adam Baker wrote:
> Gertjan van Wingerde <gwingerde@...> writes:
>
>>
>> Now that the powersave issues on rt2500usb have been tackled, powersave
>> can be enabled by default again.
>>
>> Signed-off-by: Gertjan van Wingerde <gwingerde@...>
>> ---
>> drivers/net/wireless/rt2x00/rt2500usb.c | 5 -----
>> 1 files changed, 0 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/net/wireless/rt2x00/rt2500usb.c
> b/drivers/net/wireless/rt2x00/rt2500usb.c
>> index 54d2716..c1eec17 100644
>> --- a/drivers/net/wireless/rt2x00/rt2500usb.c
>> +++ b/drivers/net/wireless/rt2x00/rt2500usb.c
>> @@ -1647,11 +1647,6 @@ static int rt2500usb_probe_hw_mode(struct rt2x00_dev
> *rt2x00dev)
>> unsigned int i;
>>
>> /*
>> - * Disable powersaving as default.
>> - */
>> - rt2x00dev->hw->wiphy->flags &= ~WIPHY_FLAG_PS_ON_BY_DEFAULT;
>>
> This looks like it deletes one line too few leaving a nested open comment
> block in the code.
>
Nope, it doesn't. This is just the peculiar way diff creates patches within git.
If you take a look at the full patch, then you'll see that the patch removes all lines
including the '/*' of the next comment.
So the end-result is still good.
---
Gertjan.
next prev parent reply other threads:[~2010-03-31 22:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-30 21:50 [PATCH 0/4] rt2x00: Powersave fixes Gertjan van Wingerde
2010-03-30 21:50 ` [PATCH 1/4] rt2x00: Disable auto wakeup before waking up device Gertjan van Wingerde
2010-03-30 21:50 ` [PATCH 2/4] rt2x00: Enable powersaving by default again on rt2500usb Gertjan van Wingerde
2010-03-31 22:29 ` Adam Baker
2010-03-31 22:34 ` Gertjan van Wingerde [this message]
2010-03-30 21:50 ` [PATCH 3/4] rt2x00: Add wakeup interrupt handler to rt61pci Gertjan van Wingerde
2010-03-30 21:50 ` [PATCH 4/4] rt2x00: Add wakeup interrupt handler to rt2800pci Gertjan van Wingerde
2010-04-06 19:34 ` [PATCH 0/4] rt2x00: Powersave fixes John W. Linville
2010-04-06 19:52 ` Gertjan van Wingerde
2010-04-06 21:18 ` John W. Linville
2010-04-06 21:26 ` Ivo van Doorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BB3CE0D.1030707@gmail.com \
--to=gwingerde@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@baker-net.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).