From: Gertjan van Wingerde <gwingerde@gmail.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: Luis Correia <luis.f.correia@gmail.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
Ivo Van Doorn <ivdoorn@gmail.com>,
rt2x00 Users List <users@rt2x00.serialmonkey.com>
Subject: Re: [PATCH V4] rt2x00: remove MCU requests for SoC platforms
Date: Sat, 03 Apr 2010 16:08:44 +0200 [thread overview]
Message-ID: <4BB74BEC.4000703@gmail.com> (raw)
In-Reply-To: <4BB745E8.6030205@gmail.com>
On 04/03/10 15:43, Gertjan van Wingerde wrote:
> On 04/03/10 13:49, Luis Correia wrote:
>> The ralink SoC platforms do not have an MCU.
>>
>> Signed-off-by: Luis Correia <luis.f.correia@gmail.com>
>
> Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>
>
>> ---
>>
>> Removed flag usage as per Gertjan suggestion.
>>
>> diff --git a/drivers/net/wireless/rt2x00/rt2800pci.c
>> b/drivers/net/wireless/rt2x00/rt2800pci.c
>> index ce7e88e..1df2d44 100644
>> --- a/drivers/net/wireless/rt2x00/rt2800pci.c
>> +++ b/drivers/net/wireless/rt2x00/rt2800pci.c
>> @@ -60,6 +60,12 @@ static void rt2800pci_mcu_status(struct rt2x00_dev
>> *rt2x00dev, const u8 token)
>> unsigned int i;
>> u32 reg;
>>
>> + /*
>> + * SOC devices don't support MCU requests.
>> + */
>> + if (rt2x00_is_soc(rt2x00dev))
>> + return;
>> +
>> for (i = 0; i < 200; i++) {
>> rt2800_register_read(rt2x00dev, H2M_MAILBOX_CID, ®);
>>
John,
This patch seems to be word-wrapped and white-space damaged. I fixed it up
and applied it to my tree.
If you want you can pull from git://git.gwingerde.nl/rt2x00-next-2.6 to
get the fixed up patch.
---
Gertjan.
next prev parent reply other threads:[~2010-04-03 14:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-01 21:14 [PATCH V3] rt2x00: remove MCU requests for SoC platforms Luis Correia
2010-04-01 21:44 ` Gertjan van Wingerde
2010-04-01 21:52 ` Luis Correia
2010-04-02 6:57 ` Ivo Van Doorn
[not found] ` <t2qefe7343f1004030447i9d6f290fvd7dd317c63b5b61@mail.gmail.com>
2010-04-03 11:49 ` [PATCH V4] " Luis Correia
2010-04-03 11:55 ` Ivo van Doorn
2010-04-03 13:43 ` Gertjan van Wingerde
2010-04-03 14:08 ` Gertjan van Wingerde [this message]
2010-04-06 20:44 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BB74BEC.4000703@gmail.com \
--to=gwingerde@gmail.com \
--cc=ivdoorn@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=luis.f.correia@gmail.com \
--cc=users@rt2x00.serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).