From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from Cpsmtpm-eml109.kpnxchange.com ([195.121.3.13]:61660 "EHLO CPSMTPM-EML109.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753835Ab0DCOIv (ORCPT ); Sat, 3 Apr 2010 10:08:51 -0400 Message-ID: <4BB74BEC.4000703@gmail.com> Date: Sat, 03 Apr 2010 16:08:44 +0200 From: Gertjan van Wingerde MIME-Version: 1.0 To: "John W. Linville" CC: Luis Correia , linux-wireless , Ivo Van Doorn , rt2x00 Users List Subject: Re: [PATCH V4] rt2x00: remove MCU requests for SoC platforms References: <4BB745E8.6030205@gmail.com> In-Reply-To: <4BB745E8.6030205@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 04/03/10 15:43, Gertjan van Wingerde wrote: > On 04/03/10 13:49, Luis Correia wrote: >> The ralink SoC platforms do not have an MCU. >> >> Signed-off-by: Luis Correia > > Acked-by: Gertjan van Wingerde > >> --- >> >> Removed flag usage as per Gertjan suggestion. >> >> diff --git a/drivers/net/wireless/rt2x00/rt2800pci.c >> b/drivers/net/wireless/rt2x00/rt2800pci.c >> index ce7e88e..1df2d44 100644 >> --- a/drivers/net/wireless/rt2x00/rt2800pci.c >> +++ b/drivers/net/wireless/rt2x00/rt2800pci.c >> @@ -60,6 +60,12 @@ static void rt2800pci_mcu_status(struct rt2x00_dev >> *rt2x00dev, const u8 token) >> unsigned int i; >> u32 reg; >> >> + /* >> + * SOC devices don't support MCU requests. >> + */ >> + if (rt2x00_is_soc(rt2x00dev)) >> + return; >> + >> for (i = 0; i < 200; i++) { >> rt2800_register_read(rt2x00dev, H2M_MAILBOX_CID, ®); >> John, This patch seems to be word-wrapped and white-space damaged. I fixed it up and applied it to my tree. If you want you can pull from git://git.gwingerde.nl/rt2x00-next-2.6 to get the fixed up patch. --- Gertjan.