* [PATCH] ath9k: fix double calls to ath_radio_enable
@ 2010-04-06 19:05 Felix Fietkau
0 siblings, 0 replies; only message in thread
From: Felix Fietkau @ 2010-04-06 19:05 UTC (permalink / raw)
To: linux-wireless; +Cc: John W. Linville, Luis R. Rodriguez
With the enable_radio being uninitialized, ath_radio_enable() might be
called twice, which can leave some hardware in an undefined state.
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Cc: stable@kernel.org
---
--- a/drivers/net/wireless/ath/ath9k/main.c
+++ b/drivers/net/wireless/ath/ath9k/main.c
@@ -1572,8 +1572,7 @@ static int ath9k_config(struct ieee80211
all_wiphys_idle = ath9k_all_wiphys_idle(sc);
ath9k_set_wiphy_idle(aphy, idle);
- if (!idle && all_wiphys_idle)
- enable_radio = true;
+ enable_radio = (!idle && all_wiphys_idle);
/*
* After we unlock here its possible another wiphy
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2010-04-06 19:05 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-06 19:05 [PATCH] ath9k: fix double calls to ath_radio_enable Felix Fietkau
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).