Linux wireless drivers development
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: "Gábor Stefanik" <netrolller.3d@gmail.com>,
	"Rafał Miłecki" <zajec5@gmail.com>,
	"Michael Buesch" <mb@bu3sch.de>
Cc: b43-dev@lists.infradead.org,
	wireless <linux-wireless@vger.kernel.org>,
	John Linville <linville@tuxdriver.com>
Subject: Changes to b43/ssb specs
Date: Mon, 26 Apr 2010 11:40:25 -0500	[thread overview]
Message-ID: <4BD5C1F9.4000701@lwfinger.net> (raw)

In Kernel Bugzilla #15825, a netbook with an LP PHY device had symptoms
similar to John's box. The main difference is that the freezes on ssb
load were intermittent. From the instances that it works, we learned
that this box does have a SPROM at the normal location (0x1000). With
the help of the OP, we also learned that when it failed, it read the
first word of the SPROM as 0xFFFF, and then froze upon trying the
second. This behavior is the basis for my submission of "[RFC/RFT] ssb:
Avoid system hang when SPROM read fails". On the box at Bug #15825, that
patch eliminates the hangs. Of course, when the load fails with the
appropriate log entries, the wireless doesn't work.

In auditing the path that is involved in ssb registration, I noted a
variable named fast_pwrup_delay in struct ssb_chipcommon that gets
written to MMIO offset 0x6A8. When I looked for some variable like this
in the Broadcom driver, I found that it should be set to 7000 for the
BCM4312 LP-PHY device, but a test print showed it to be 0 with b43/ssb.

Resolving the discrepancy led to modifications in the specs at
http://bcm-v4.sipsolutions.net/802.11/Init. In particular, line 11 was
added. There are now two new pages at
http://bcm-v4.sipsolutions.net/802.11/ClkctlFastPwrupDelay, and
http://bcm-v4.sipsolutions.net/802.11/PmuFastPwrupDelay.

I hand coded the driver to write 7000, rather than zero, to the MMIO
offset 0x6A8. For my device, which already works, it made no difference.
I have sent such a trial patch to the OP at Bug #15825, but have not
gotten feedback.

Larry

                 reply	other threads:[~2010-04-26 16:40 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BD5C1F9.4000701@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=b43-dev@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=mb@bu3sch.de \
    --cc=netrolller.3d@gmail.com \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox