* [PATCH] rt2x00: remove usage of deprecated noise value
@ 2010-04-26 20:09 John W. Linville
2010-04-26 20:46 ` Gertjan van Wingerde
0 siblings, 1 reply; 2+ messages in thread
From: John W. Linville @ 2010-04-26 20:09 UTC (permalink / raw)
To: linux-wireless; +Cc: John W. Linville
Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
drivers/net/wireless/rt2x00/rt2x00dev.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/rt2x00/rt2x00dev.c b/drivers/net/wireless/rt2x00/rt2x00dev.c
index b93731b..33c2f5f 100644
--- a/drivers/net/wireless/rt2x00/rt2x00dev.c
+++ b/drivers/net/wireless/rt2x00/rt2x00dev.c
@@ -434,7 +434,6 @@ void rt2x00lib_rxdone(struct rt2x00_dev *rt2x00dev,
rx_status->mactime = rxdesc.timestamp;
rx_status->rate_idx = rate_idx;
rx_status->signal = rxdesc.rssi;
- rx_status->noise = rxdesc.noise;
rx_status->flag = rxdesc.flags;
rx_status->antenna = rt2x00dev->link.ant.active.rx;
--
1.6.6.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rt2x00: remove usage of deprecated noise value
2010-04-26 20:09 [PATCH] rt2x00: remove usage of deprecated noise value John W. Linville
@ 2010-04-26 20:46 ` Gertjan van Wingerde
0 siblings, 0 replies; 2+ messages in thread
From: Gertjan van Wingerde @ 2010-04-26 20:46 UTC (permalink / raw)
To: John W. Linville; +Cc: linux-wireless
On 04/26/10 22:09, John W. Linville wrote:
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
> ---
> drivers/net/wireless/rt2x00/rt2x00dev.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2x00dev.c b/drivers/net/wireless/rt2x00/rt2x00dev.c
> index b93731b..33c2f5f 100644
> --- a/drivers/net/wireless/rt2x00/rt2x00dev.c
> +++ b/drivers/net/wireless/rt2x00/rt2x00dev.c
> @@ -434,7 +434,6 @@ void rt2x00lib_rxdone(struct rt2x00_dev *rt2x00dev,
> rx_status->mactime = rxdesc.timestamp;
> rx_status->rate_idx = rate_idx;
> rx_status->signal = rxdesc.rssi;
> - rx_status->noise = rxdesc.noise;
> rx_status->flag = rxdesc.flags;
> rx_status->antenna = rt2x00dev->link.ant.active.rx;
>
This could actually go further than just this, as the noise field of rxdesc is only used for this
purpose, so it can actually be removed as well.
However, I guess that can be done as a follow-up, so:
Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-04-26 20:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-26 20:09 [PATCH] rt2x00: remove usage of deprecated noise value John W. Linville
2010-04-26 20:46 ` Gertjan van Wingerde
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).