* [PATCH] ath9k: remove usage of deprecated noise value @ 2010-04-26 20:09 John W. Linville 2010-04-27 6:22 ` Benoit PAPILLAULT 0 siblings, 1 reply; 6+ messages in thread From: John W. Linville @ 2010-04-26 20:09 UTC (permalink / raw) To: linux-wireless; +Cc: John W. Linville Signed-off-by: John W. Linville <linville@tuxdriver.com> --- drivers/net/wireless/ath/ath9k/common.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/common.c b/drivers/net/wireless/ath/ath9k/common.c index 09effde..b4424a6 100644 --- a/drivers/net/wireless/ath/ath9k/common.c +++ b/drivers/net/wireless/ath/ath9k/common.c @@ -212,7 +212,6 @@ int ath9k_cmn_rx_skb_preprocess(struct ath_common *common, rx_status->mactime = ath9k_hw_extend_tsf(ah, rx_stats->rs_tstamp); rx_status->band = hw->conf.channel->band; rx_status->freq = hw->conf.channel->center_freq; - rx_status->noise = common->ani.noise_floor; rx_status->signal = ATH_DEFAULT_NOISE_FLOOR + rx_stats->rs_rssi; rx_status->antenna = rx_stats->rs_antenna; rx_status->flag |= RX_FLAG_TSFT; -- 1.6.6.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ath9k: remove usage of deprecated noise value 2010-04-26 20:09 [PATCH] ath9k: remove usage of deprecated noise value John W. Linville @ 2010-04-27 6:22 ` Benoit PAPILLAULT 2010-04-27 10:55 ` Joerg Pommnitz 0 siblings, 1 reply; 6+ messages in thread From: Benoit PAPILLAULT @ 2010-04-27 6:22 UTC (permalink / raw) To: John W. Linville; +Cc: linux-wireless John W. Linville a écrit : > Signed-off-by: John W. Linville <linville@tuxdriver.com> > --- > drivers/net/wireless/ath/ath9k/common.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath9k/common.c b/drivers/net/wireless/ath/ath9k/common.c > index 09effde..b4424a6 100644 > --- a/drivers/net/wireless/ath/ath9k/common.c > +++ b/drivers/net/wireless/ath/ath9k/common.c > @@ -212,7 +212,6 @@ int ath9k_cmn_rx_skb_preprocess(struct ath_common *common, > rx_status->mactime = ath9k_hw_extend_tsf(ah, rx_stats->rs_tstamp); > rx_status->band = hw->conf.channel->band; > rx_status->freq = hw->conf.channel->center_freq; > - rx_status->noise = common->ani.noise_floor; > rx_status->signal = ATH_DEFAULT_NOISE_FLOOR + rx_stats->rs_rssi; > rx_status->antenna = rx_stats->rs_antenna; > rx_status->flag |= RX_FLAG_TSFT; > Hey, I'm still using this value here in my setup (I've done some work on noise floor calibration and can submit a patch that report noise & signal values that makes more sense to me). I mentioned in an earlier patch that I was using the {last_signal, last_noise} debugfs file as well (in February, 17th). Before removing noise reporting and all related code, wouln't it be better to have a replacement API? I was told that noise reporting is buggy for most chipset, but that's a bug in each driver, not in mac80211 then. Such bugs could be fixed by using a default value of -101dBm (thermal noise at room temperature over a 20 MHz channel) if they are unable to determine a correct value. Moreover, it is very convenient to have the {last_signal, last_noise} sampled at the same time and be in the same location. Likewise for the radiotap header, it is very easy to plot noise value over time if it is stored on a per packet basis. Of course, I know noise is a global property of the channel and not DEFINED on a per packet basis, but once you know that, it's still useful to have it REPORTED on a per packet basis. So far, the solution for me was to revert the single patch for making the noise field deprecated, but I'm not going to revert each & every patches related to noise. After all, isn't it the purpose of peer review? Regards, Benoit ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ath9k: remove usage of deprecated noise value 2010-04-27 6:22 ` Benoit PAPILLAULT @ 2010-04-27 10:55 ` Joerg Pommnitz 2010-04-27 19:23 ` Benoit PAPILLAULT 0 siblings, 1 reply; 6+ messages in thread From: Joerg Pommnitz @ 2010-04-27 10:55 UTC (permalink / raw) To: linux-wireless Benoit PAPILLAULT <benoit.papillault@...> writes: > Before removing noise reporting and all related code, wouln't it be > better to have a replacement API? I thought this is what NL80211_CMD_GET_SURVEY is supposed to do... See http://osdir.com/ml/linux-wireless/2009-11/msg00977.html ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ath9k: remove usage of deprecated noise value 2010-04-27 10:55 ` Joerg Pommnitz @ 2010-04-27 19:23 ` Benoit PAPILLAULT 2010-04-28 19:38 ` AW: " Joerg Pommnitz 0 siblings, 1 reply; 6+ messages in thread From: Benoit PAPILLAULT @ 2010-04-27 19:23 UTC (permalink / raw) To: Joerg Pommnitz; +Cc: linux-wireless Joerg Pommnitz a écrit : > Benoit PAPILLAULT <benoit.papillault@...> writes: > >> Before removing noise reporting and all related code, wouln't it be >> better to have a replacement API? >> > > I thought this is what NL80211_CMD_GET_SURVEY is supposed to do... > See > http://osdir.com/ml/linux-wireless/2009-11/msg00977.html > > Thanks Joerg! I tried : iw dev wlan0 survey dump and nothing show up. What drivers are supposed to have this feature implemented? Anyway, I really like to have it implemented for ath9k before removing the deprecated noise value. If it's not currently implemented, I'll try my best to send a patch in the next couple of days. I'll try then to implement it for ath5k (already done?), ar9170, zd1211rw (if possible), rt2800usb/pci. BTW, on rt2800usb/pci, it seems the noise is reported on a per packet basis by HW. Kinda strange isn't it? :-] Regards, Benoit ^ permalink raw reply [flat|nested] 6+ messages in thread
* AW: [PATCH] ath9k: remove usage of deprecated noise value 2010-04-27 19:23 ` Benoit PAPILLAULT @ 2010-04-28 19:38 ` Joerg Pommnitz 2010-04-28 20:06 ` Benoit PAPILLAULT 0 siblings, 1 reply; 6+ messages in thread From: Joerg Pommnitz @ 2010-04-28 19:38 UTC (permalink / raw) To: Benoit PAPILLAULT; +Cc: linux-wireless ----- Ursprüngliche Mail ---- > From: Benoit PAPILLAULT <benoit.papillault@free.fr> > I'll try then to implement it for ath5k (already done?), ar9170, > zd1211rw (if possible), rt2800usb/pci. For ath5k see http://git.kernel.org/?p=linux/kernel/git/linville/wireless-testing.git;a=commit;h=55ee82b500551f80720de57a00d2990d56cf08a8 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: AW: [PATCH] ath9k: remove usage of deprecated noise value 2010-04-28 19:38 ` AW: " Joerg Pommnitz @ 2010-04-28 20:06 ` Benoit PAPILLAULT 0 siblings, 0 replies; 6+ messages in thread From: Benoit PAPILLAULT @ 2010-04-28 20:06 UTC (permalink / raw) To: Joerg Pommnitz; +Cc: linux-wireless Joerg Pommnitz a écrit : > ----- Ursprüngliche Mail ---- > > >> From: Benoit PAPILLAULT <benoit.papillault@free.fr> >> I'll try then to implement it for ath5k (already done?), ar9170, >> zd1211rw (if possible), rt2800usb/pci. >> > For ath5k see > http://git.kernel.org/?p=linux/kernel/git/linville/wireless-testing.git;a=commit;h=55ee82b500551f80720de57a00d2990d56cf08a8 > > > > Thanks. I've used that for the ath9k variant. Regards, Benoit ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-04-28 20:06 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2010-04-26 20:09 [PATCH] ath9k: remove usage of deprecated noise value John W. Linville 2010-04-27 6:22 ` Benoit PAPILLAULT 2010-04-27 10:55 ` Joerg Pommnitz 2010-04-27 19:23 ` Benoit PAPILLAULT 2010-04-28 19:38 ` AW: " Joerg Pommnitz 2010-04-28 20:06 ` Benoit PAPILLAULT
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).