From: Gertjan van Wingerde <gwingerde@gmail.com>
To: cabtobma@tuxdriver.com
Cc: linux-wireless@vger.kernel.org, ivdoorn@gmail.com,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH] rt2x00: remove now unused noise field from struct rxdone_entry_desc
Date: Thu, 29 Apr 2010 00:04:11 +0200 [thread overview]
Message-ID: <4BD8B0DB.1010902@gmail.com> (raw)
In-Reply-To: <1272488452-21288-1-git-send-email-cabtobma>
On 04/28/10 23:00, cabtobma@tuxdriver.com wrote:
> From: John W. Linville <linville@tuxdriver.com>
>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>
> ---
> drivers/net/wireless/rt2x00/rt2800pci.c | 4 ----
> drivers/net/wireless/rt2x00/rt2800usb.c | 4 ----
> drivers/net/wireless/rt2x00/rt2x00queue.h | 2 --
> 3 files changed, 0 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2800pci.c b/drivers/net/wireless/rt2x00/rt2800pci.c
> index 0e52f17..89281d7 100644
> --- a/drivers/net/wireless/rt2x00/rt2800pci.c
> +++ b/drivers/net/wireless/rt2x00/rt2800pci.c
> @@ -895,10 +895,6 @@ static void rt2800pci_fill_rxdone(struct queue_entry *entry,
> (rt2x00_get_field32(rxwi2, RXWI_W2_RSSI0) +
> rt2x00_get_field32(rxwi2, RXWI_W2_RSSI1)) / 2;
>
> - rxdesc->noise =
> - (rt2x00_get_field32(rxwi3, RXWI_W3_SNR0) +
> - rt2x00_get_field32(rxwi3, RXWI_W3_SNR1)) / 2;
> -
> rxdesc->size = rt2x00_get_field32(rxwi0, RXWI_W0_MPDU_TOTAL_BYTE_COUNT);
>
> /*
> diff --git a/drivers/net/wireless/rt2x00/rt2800usb.c b/drivers/net/wireless/rt2x00/rt2800usb.c
> index a716156..6f2a945 100644
> --- a/drivers/net/wireless/rt2x00/rt2800usb.c
> +++ b/drivers/net/wireless/rt2x00/rt2800usb.c
> @@ -645,10 +645,6 @@ static void rt2800usb_fill_rxdone(struct queue_entry *entry,
> (rt2x00_get_field32(rxwi2, RXWI_W2_RSSI0) +
> rt2x00_get_field32(rxwi2, RXWI_W2_RSSI1)) / 2;
>
> - rxdesc->noise =
> - (rt2x00_get_field32(rxwi3, RXWI_W3_SNR0) +
> - rt2x00_get_field32(rxwi3, RXWI_W3_SNR1)) / 2;
> -
> rxdesc->size = rt2x00_get_field32(rxwi0, RXWI_W0_MPDU_TOTAL_BYTE_COUNT);
>
> /*
> diff --git a/drivers/net/wireless/rt2x00/rt2x00queue.h b/drivers/net/wireless/rt2x00/rt2x00queue.h
> index c1e482b..f519aba 100644
> --- a/drivers/net/wireless/rt2x00/rt2x00queue.h
> +++ b/drivers/net/wireless/rt2x00/rt2x00queue.h
> @@ -183,7 +183,6 @@ enum rxdone_entry_desc_flags {
> * @timestamp: RX Timestamp
> * @signal: Signal of the received frame.
> * @rssi: RSSI of the received frame.
> - * @noise: Measured noise during frame reception.
> * @size: Data size of the received frame.
> * @flags: MAC80211 receive flags (See &enum mac80211_rx_flags).
> * @dev_flags: Ralink receive flags (See &enum rxdone_entry_desc_flags).
> @@ -197,7 +196,6 @@ struct rxdone_entry_desc {
> u64 timestamp;
> int signal;
> int rssi;
> - int noise;
> int size;
> int flags;
> int dev_flags;
prev parent reply other threads:[~2010-04-28 22:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-28 21:00 [PATCH] rt2x00: remove now unused noise field from struct rxdone_entry_desc cabtobma
2010-04-28 22:04 ` Gertjan van Wingerde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BD8B0DB.1010902@gmail.com \
--to=gwingerde@gmail.com \
--cc=cabtobma@tuxdriver.com \
--cc=ivdoorn@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).