From: Larry Finger <Larry.Finger@lwfinger.net>
To: Michael Buesch <mb@bu3sch.de>
Cc: "Gábor Stefanik" <netrolller.3d@gmail.com>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
b43-dev <b43-dev@lists.infradead.org>
Subject: Re: [PATCH] ssb: Implement fast powerup delay calculation
Date: Sat, 01 May 2010 13:27:42 -0500 [thread overview]
Message-ID: <4BDC729E.5060202@lwfinger.net> (raw)
In-Reply-To: <201005012015.50601.mb@bu3sch.de>
On 05/01/2010 01:15 PM, Michael Buesch wrote:
> On Saturday 01 May 2010 19:42:27 Larry Finger wrote:
>> I may have gotten the MMIO offset part wrong in the specs, but the
>> Broadcom driver definitely writes to offset 0x648 at that point.
>
> I do not think you are right.
>
> First: The write has to happen to the 802.11 core and not to the chipcommon core.
>
> Second: The code that was touched by Gábor is _very_ early in the SSB init.
> Way ahead of the wireless core init. The specs state that the delay value has to be written
> after the wireless core init is nearly done.
> We do _exactly_ that in b43.
>
> The only thing that needs to be done is to add the additional switch statement.
> No MMIO writes have to be touched.
OK, I changed the spec to remove the write.
Larry
next prev parent reply other threads:[~2010-05-01 18:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-01 16:29 [PATCH] ssb: Implement fast powerup delay calculation Gábor Stefanik
2010-05-01 16:32 ` Gábor Stefanik
2010-05-01 17:07 ` Michael Buesch
2010-05-01 17:13 ` Gábor Stefanik
2010-05-01 17:19 ` Gábor Stefanik
2010-05-01 17:19 ` Michael Buesch
2010-05-01 17:42 ` Larry Finger
2010-05-01 17:48 ` Gábor Stefanik
2010-05-01 18:15 ` Michael Buesch
2010-05-01 18:27 ` Larry Finger [this message]
2010-05-01 18:40 ` Michael Buesch
2010-05-01 18:43 ` Gábor Stefanik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BDC729E.5060202@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=b43-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
--cc=netrolller.3d@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox