linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benoit Papillault <benoit.papillault@free.fr>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC] ibss: Added channel type in order to create HT IBSS
Date: Sun, 02 May 2010 22:05:20 +0200	[thread overview]
Message-ID: <4BDDDB00.90207@free.fr> (raw)
In-Reply-To: <1272817974.31265.0.camel@jlt3.sipsolutions.net>

Le 02/05/2010 18:32, Johannes Berg a écrit :
> On Sun, 2010-05-02 at 16:12 +0200, Benoit Papillault wrote:
>> When joining an IBSS, the parameters can be used to create the IBSS. As
>> such, we need to know if the user wants to create an HT IBSS or not.
>> This is accomplish by passing the channel type (ie ht20, ht40- or
>> ht40+). Default is to create a non HT IBSS.
>>
>> Signed-off-by: Benoit Papillault<benoit.papillault@free.fr>
>> ---
>> It is needed for upcoming patches regarding HT IBSS
>>   ibss.c |   27 ++++++++++++++++++++++++++-
>>   1 files changed, 26 insertions(+), 1 deletions(-)
>>
>> diff --git a/ibss.c b/ibss.c
>> index 4715ac8..4003a38 100644
>> --- a/ibss.c
>> +++ b/ibss.c
>> @@ -18,6 +18,15 @@ static int join_ibss(struct nl80211_state *state,
>>   {
>>   	char *end;
>>   	unsigned char abssid[6];
>> +	int i;
>> +	static const struct {
>> +		const char *name;
>> +		unsigned int val;
>> +	} htmap[] = {
>> +		{ .name = "HT20", .val = NL80211_CHAN_HT20, },
>> +		{ .name = "HT40+", .val = NL80211_CHAN_HT40PLUS, },
>> +		{ .name = "HT40-", .val = NL80211_CHAN_HT40MINUS, },
>> +	};
>
> There's code to do something like this already when setting the channel,
> please factor it out and use it in both places.
>
> johannes
>

Agreed. I did a copy/paste in the hurry, my bad.
I am going to post an update ASAP.

Regards,
Benoit

      reply	other threads:[~2010-05-02 20:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-02 14:12 [RFC] ibss: Added channel type in order to create HT IBSS Benoit Papillault
2010-05-02 16:32 ` Johannes Berg
2010-05-02 20:05   ` Benoit Papillault [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BDDDB00.90207@free.fr \
    --to=benoit.papillault@free.fr \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).