From: Benoit Papillault <benoit.papillault@free.fr>
To: rt2x00 Users List <users@rt2x00.serialmonkey.com>
Cc: Gertjan van Wingerde <gwingerde@gmail.com>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [rt2x00-users] [PATCH 3/4] rt2x00: Fix HT40+/HT40- setting in rt2800.
Date: Thu, 06 May 2010 08:26:43 +0200 [thread overview]
Message-ID: <4BE26123.5040209@free.fr> (raw)
In-Reply-To: <1272919385-18004-4-git-send-email-gwingerde@gmail.com>
Le 03/05/2010 22:43, Gertjan van Wingerde a écrit :
> Inspection of the Ralink vendor driver shows that the TX_BAND_CFG register
> and BBP register 3 are about HT40- indication, not about HT40+ indication.
> Inverse the meaning of these fields in the code.
>
> Signed-off-by: Gertjan van Wingerde<gwingerde@gmail.com>
Acked-by: Benoit Papillault <benoit.papillault@free.fr>
> ---
> drivers/net/wireless/rt2x00/rt2800.h | 4 ++--
> drivers/net/wireless/rt2x00/rt2800lib.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2800.h b/drivers/net/wireless/rt2x00/rt2800.h
> index 4c0b481..2aa0375 100644
> --- a/drivers/net/wireless/rt2x00/rt2800.h
> +++ b/drivers/net/wireless/rt2x00/rt2800.h
> @@ -845,7 +845,7 @@
> * TX_BAND_CFG: 0x1 use upper 20MHz, 0x0 use lower 20MHz
> */
> #define TX_BAND_CFG 0x132c
> -#define TX_BAND_CFG_HT40_PLUS FIELD32(0x00000001)
> +#define TX_BAND_CFG_HT40_MINUS FIELD32(0x00000001)
> #define TX_BAND_CFG_A FIELD32(0x00000002)
> #define TX_BAND_CFG_BG FIELD32(0x00000004)
>
> @@ -1519,7 +1519,7 @@ struct mac_iveiv_entry {
> * BBP 3: RX Antenna
> */
> #define BBP3_RX_ANTENNA FIELD8(0x18)
> -#define BBP3_HT40_PLUS FIELD8(0x20)
> +#define BBP3_HT40_MINUS FIELD8(0x20)
>
> /*
> * BBP 4: Bandwidth
> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
> index 7310f34..6d2c66d 100644
> --- a/drivers/net/wireless/rt2x00/rt2800lib.c
> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
> @@ -867,7 +867,7 @@ static void rt2800_config_channel(struct rt2x00_dev *rt2x00dev,
> }
>
> rt2800_register_read(rt2x00dev, TX_BAND_CFG,®);
> - rt2x00_set_field32(®, TX_BAND_CFG_HT40_PLUS, conf_is_ht40_plus(conf));
> + rt2x00_set_field32(®, TX_BAND_CFG_HT40_MINUS, conf_is_ht40_minus(conf));
> rt2x00_set_field32(®, TX_BAND_CFG_A, rf->channel> 14);
> rt2x00_set_field32(®, TX_BAND_CFG_BG, rf->channel<= 14);
> rt2800_register_write(rt2x00dev, TX_BAND_CFG, reg);
> @@ -900,7 +900,7 @@ static void rt2800_config_channel(struct rt2x00_dev *rt2x00dev,
> rt2800_bbp_write(rt2x00dev, 4, bbp);
>
> rt2800_bbp_read(rt2x00dev, 3,&bbp);
> - rt2x00_set_field8(&bbp, BBP3_HT40_PLUS, conf_is_ht40_plus(conf));
> + rt2x00_set_field8(&bbp, BBP3_HT40_MINUS, conf_is_ht40_minus(conf));
> rt2800_bbp_write(rt2x00dev, 3, bbp);
>
> if (rt2x00_rt_rev(rt2x00dev, RT2860, REV_RT2860C)) {
next prev parent reply other threads:[~2010-05-06 6:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-03 20:43 [PATCH 0/4] rt2x00: Assorted fixes and cleanups Gertjan van Wingerde
2010-05-03 20:43 ` [PATCH 1/4] rt2x00: Remove rt2x00pci.h include from rt2800lib Gertjan van Wingerde
2010-05-03 20:43 ` [PATCH 2/4] rt2x00: Enable RT30xx by default Gertjan van Wingerde
2010-05-03 20:59 ` Pavel Roskin
2010-05-03 22:08 ` Stefan Lippers-Hollmann
2010-05-03 22:44 ` Pavel Roskin
2010-05-04 3:31 ` Gertjan van Wingerde
2010-05-04 17:17 ` John W. Linville
2010-05-04 18:22 ` Gertjan van Wingerde
2010-05-04 19:09 ` Walter Goldens
2010-05-04 19:13 ` Gertjan van Wingerde
2010-05-03 20:43 ` [PATCH 3/4] rt2x00: Fix HT40+/HT40- setting in rt2800 Gertjan van Wingerde
2010-05-06 6:26 ` Benoit Papillault [this message]
2010-05-03 20:43 ` [PATCH 4/4] rt2x00: Register frame length in TX entry descriptor instead of L2PAD Gertjan van Wingerde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BE26123.5040209@free.fr \
--to=benoit.papillault@free.fr \
--cc=gwingerde@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=users@rt2x00.serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).