From: "Justin P. Mattock" <justinmattock@gmail.com>
To: "Luis R. Rodriguez" <mcgrof@gmail.com>
Cc: linville@tuxdriver.com, arnd@arndnet.de, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath9k: Fix ath_print in xmit for harware reset.
Date: Wed, 26 May 2010 11:01:47 -0700 [thread overview]
Message-ID: <4BFD620B.8010301@gmail.com> (raw)
In-Reply-To: <AANLkTimrFUYIkTQ7ev-AL0V8y0Lot064h8JK_fU81Lyr@mail.gmail.com>
On 05/26/2010 10:50 AM, Luis R. Rodriguez wrote:
> On Wed, May 26, 2010 at 10:46 AM, Justin P. Mattock
> <justinmattock@gmail.com> wrote:
>
>> ath_print in xmit.c should say "Reseting hardware"
>> instead of Resetting HAL!(since HAL is being fazed out).
>> dmesg shows:
>> [ 8660.899624] ath: Failed to stop TX DMA in 100 msec after killing last frame
>> [ 8660.899676] ath: Unable to stop TxDMA. Reset HAL!
>>
>> Signed-off-by: Justin P. Mattock<justinmattock@gmail.com>
>>
>> ---
>> drivers/net/wireless/ath/ath9k/xmit.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath9k/xmit.c b/drivers/net/wireless/ath/ath9k/xmit.c
>> index 3db1917..617db8e 100644
>> --- a/drivers/net/wireless/ath/ath9k/xmit.c
>> +++ b/drivers/net/wireless/ath/ath9k/xmit.c
>> @@ -1198,7 +1198,7 @@ void ath_drain_all_txq(struct ath_softc *sc, bool retry_tx)
>> int r;
>>
>> ath_print(common, ATH_DBG_FATAL,
>> - "Unable to stop TxDMA. Reset HAL!\n");
>> + "ath9k: Failed to stop TX DMA. Resetting hardware!\n");
>>
> Nack, No need to put "ath9k:" since ath_print already prepends "ath: "
>
> Luis
>
>
ah.. so the ATH_DBG_FATAL takes care of that?
resent..
Justin P. Mattock
next prev parent reply other threads:[~2010-05-26 18:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 17:46 [PATCH] ath9k: Fix ath_print in xmit for harware reset Justin P. Mattock
2010-05-26 17:50 ` Luis R. Rodriguez
2010-05-26 18:01 ` Justin P. Mattock [this message]
2010-05-26 18:03 ` Luis R. Rodriguez
2010-05-26 18:08 ` Justin P. Mattock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BFD620B.8010301@gmail.com \
--to=justinmattock@gmail.com \
--cc=arnd@arndnet.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).