* [PATCH][RESEND] ath9k: Fix ath_print in xmit for hardware reset.
@ 2010-05-26 18:00 Justin P. Mattock
2010-05-26 18:02 ` Luis R. Rodriguez
0 siblings, 1 reply; 7+ messages in thread
From: Justin P. Mattock @ 2010-05-26 18:00 UTC (permalink / raw)
To: linville; +Cc: arnd, linux-wireless, mcgrof, Justin P. Mattock
ath_print in xmit.c should say "Reseting hardware"
instead of Resetting HAL!(since HAL is being fazed out).
dmesg shows:
[ 8660.899624] ath: Failed to stop TX DMA in 100 msec after killing last frame
[ 8660.899676] ath: Unable to stop TxDMA. Reset HAL!
Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
---
drivers/net/wireless/ath/ath9k/xmit.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/xmit.c b/drivers/net/wireless/ath/ath9k/xmit.c
index 3db1917..09cb13c 100644
--- a/drivers/net/wireless/ath/ath9k/xmit.c
+++ b/drivers/net/wireless/ath/ath9k/xmit.c
@@ -1198,7 +1198,7 @@ void ath_drain_all_txq(struct ath_softc *sc, bool retry_tx)
int r;
ath_print(common, ATH_DBG_FATAL,
- "Unable to stop TxDMA. Reset HAL!\n");
+ "Failed to stop TX DMA. Resetting hardware!\n");
spin_lock_bh(&sc->sc_resetlock);
r = ath9k_hw_reset(ah, sc->sc_ah->curchan, false);
--
1.6.5.GIT
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH][RESEND] ath9k: Fix ath_print in xmit for hardware reset.
2010-05-26 18:00 [PATCH][RESEND] ath9k: Fix ath_print in xmit for hardware reset Justin P. Mattock
@ 2010-05-26 18:02 ` Luis R. Rodriguez
2010-05-26 18:07 ` Justin P. Mattock
0 siblings, 1 reply; 7+ messages in thread
From: Luis R. Rodriguez @ 2010-05-26 18:02 UTC (permalink / raw)
To: Justin P. Mattock; +Cc: linville, arnd, linux-wireless
On Wed, May 26, 2010 at 11:00 AM, Justin P. Mattock
<justinmattock@gmail.com> wrote:
> ath_print in xmit.c should say "Reseting hardware"
> instead of Resetting HAL!(since HAL is being fazed out).
> dmesg shows:
> [ 8660.899624] ath: Failed to stop TX DMA in 100 msec after killing last frame
> [ 8660.899676] ath: Unable to stop TxDMA. Reset HAL!
>
> Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
>
For next time, no need for extra spaces between the SOB and the ---.
And instead of RESEND do [PATCH v2]. Please read:
http://wireless.kernel.org/en/developers/Documentation/git-guide
> ---
> drivers/net/wireless/ath/ath9k/xmit.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/xmit.c b/drivers/net/wireless/ath/ath9k/xmit.c
> index 3db1917..09cb13c 100644
> --- a/drivers/net/wireless/ath/ath9k/xmit.c
> +++ b/drivers/net/wireless/ath/ath9k/xmit.c
> @@ -1198,7 +1198,7 @@ void ath_drain_all_txq(struct ath_softc *sc, bool retry_tx)
> int r;
>
> ath_print(common, ATH_DBG_FATAL,
> - "Unable to stop TxDMA. Reset HAL!\n");
> + "Failed to stop TX DMA. Resetting hardware!\n");
>
> spin_lock_bh(&sc->sc_resetlock);
> r = ath9k_hw_reset(ah, sc->sc_ah->curchan, false);
Thanks, this is good.
Luis
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH][RESEND] ath9k: Fix ath_print in xmit for hardware reset.
2010-05-26 18:02 ` Luis R. Rodriguez
@ 2010-05-26 18:07 ` Justin P. Mattock
2010-05-26 18:09 ` Luis R. Rodriguez
0 siblings, 1 reply; 7+ messages in thread
From: Justin P. Mattock @ 2010-05-26 18:07 UTC (permalink / raw)
To: Luis R. Rodriguez; +Cc: linville, arnd, linux-wireless
On 05/26/2010 11:02 AM, Luis R. Rodriguez wrote:
> On Wed, May 26, 2010 at 11:00 AM, Justin P. Mattock
> <justinmattock@gmail.com> wrote:
>
>> ath_print in xmit.c should say "Reseting hardware"
>> instead of Resetting HAL!(since HAL is being fazed out).
>> dmesg shows:
>> [ 8660.899624] ath: Failed to stop TX DMA in 100 msec after killing last frame
>> [ 8660.899676] ath: Unable to stop TxDMA. Reset HAL!
>>
>> Signed-off-by: Justin P. Mattock<justinmattock@gmail.com>
>>
>>
> For next time, no need for extra spaces between the SOB and the ---.
> And instead of RESEND do [PATCH v2]. Please read:
>
> http://wireless.kernel.org/en/developers/Documentation/git-guide
>
>
o.k.!!
>> ---
>> drivers/net/wireless/ath/ath9k/xmit.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath9k/xmit.c b/drivers/net/wireless/ath/ath9k/xmit.c
>> index 3db1917..09cb13c 100644
>> --- a/drivers/net/wireless/ath/ath9k/xmit.c
>> +++ b/drivers/net/wireless/ath/ath9k/xmit.c
>> @@ -1198,7 +1198,7 @@ void ath_drain_all_txq(struct ath_softc *sc, bool retry_tx)
>> int r;
>>
>> ath_print(common, ATH_DBG_FATAL,
>> - "Unable to stop TxDMA. Reset HAL!\n");
>> + "Failed to stop TX DMA. Resetting hardware!\n");
>>
>> spin_lock_bh(&sc->sc_resetlock);
>> r = ath9k_hw_reset(ah, sc->sc_ah->curchan, false);
>>
> Thanks, this is good.
>
> Luis
>
>
what about all the signed-off's? should I
resend with all of those, or no?
Justin P. Mattock
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH][RESEND] ath9k: Fix ath_print in xmit for hardware reset.
2010-05-26 18:07 ` Justin P. Mattock
@ 2010-05-26 18:09 ` Luis R. Rodriguez
2010-05-26 18:12 ` Justin P. Mattock
0 siblings, 1 reply; 7+ messages in thread
From: Luis R. Rodriguez @ 2010-05-26 18:09 UTC (permalink / raw)
To: Justin P. Mattock; +Cc: linville, arnd, linux-wireless
On Wed, May 26, 2010 at 11:07 AM, Justin P. Mattock
<justinmattock@gmail.com> wrote:
> On 05/26/2010 11:02 AM, Luis R. Rodriguez wrote:
>>
>> On Wed, May 26, 2010 at 11:00 AM, Justin P. Mattock
>> <justinmattock@gmail.com> wrote:
>>
>>>
>>> ath_print in xmit.c should say "Reseting hardware"
>>> instead of Resetting HAL!(since HAL is being fazed out).
>>> dmesg shows:
>>> [ 8660.899624] ath: Failed to stop TX DMA in 100 msec after killing last
>>> frame
>>> [ 8660.899676] ath: Unable to stop TxDMA. Reset HAL!
>>>
>>> Signed-off-by: Justin P. Mattock<justinmattock@gmail.com>
>>>
>>>
>>
>> For next time, no need for extra spaces between the SOB and the ---.
>> And instead of RESEND do [PATCH v2]. Please read:
>>
>> http://wireless.kernel.org/en/developers/Documentation/git-guide
>>
>>
>
> o.k.!!
>>>
>>> ---
>>> drivers/net/wireless/ath/ath9k/xmit.c | 2 +-
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/drivers/net/wireless/ath/ath9k/xmit.c
>>> b/drivers/net/wireless/ath/ath9k/xmit.c
>>> index 3db1917..09cb13c 100644
>>> --- a/drivers/net/wireless/ath/ath9k/xmit.c
>>> +++ b/drivers/net/wireless/ath/ath9k/xmit.c
>>> @@ -1198,7 +1198,7 @@ void ath_drain_all_txq(struct ath_softc *sc, bool
>>> retry_tx)
>>> int r;
>>>
>>> ath_print(common, ATH_DBG_FATAL,
>>> - "Unable to stop TxDMA. Reset HAL!\n");
>>> + "Failed to stop TX DMA. Resetting
>>> hardware!\n");
>>>
>>> spin_lock_bh(&sc->sc_resetlock);
>>> r = ath9k_hw_reset(ah, sc->sc_ah->curchan, false);
>>>
>>
>> Thanks, this is good.
>>
>> Luis
>>
>>
>
> what about all the signed-off's? should I
> resend with all of those, or no?
I do not get what you are asking.
Luis
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH][RESEND] ath9k: Fix ath_print in xmit for hardware reset.
2010-05-26 18:09 ` Luis R. Rodriguez
@ 2010-05-26 18:12 ` Justin P. Mattock
2010-05-26 18:14 ` Luis R. Rodriguez
0 siblings, 1 reply; 7+ messages in thread
From: Justin P. Mattock @ 2010-05-26 18:12 UTC (permalink / raw)
To: Luis R. Rodriguez; +Cc: linville, arnd, linux-wireless
On 05/26/2010 11:09 AM, Luis R. Rodriguez wrote:
> On Wed, May 26, 2010 at 11:07 AM, Justin P. Mattock
> <justinmattock@gmail.com> wrote:
>
>> On 05/26/2010 11:02 AM, Luis R. Rodriguez wrote:
>>
>>> On Wed, May 26, 2010 at 11:00 AM, Justin P. Mattock
>>> <justinmattock@gmail.com> wrote:
>>>
>>>
>>>> ath_print in xmit.c should say "Reseting hardware"
>>>> instead of Resetting HAL!(since HAL is being fazed out).
>>>> dmesg shows:
>>>> [ 8660.899624] ath: Failed to stop TX DMA in 100 msec after killing last
>>>> frame
>>>> [ 8660.899676] ath: Unable to stop TxDMA. Reset HAL!
>>>>
>>>> Signed-off-by: Justin P. Mattock<justinmattock@gmail.com>
>>>>
>>>>
>>>>
>>> For next time, no need for extra spaces between the SOB and the ---.
>>> And instead of RESEND do [PATCH v2]. Please read:
>>>
>>> http://wireless.kernel.org/en/developers/Documentation/git-guide
>>>
>>>
>>>
>> o.k.!!
>>
>>>> ---
>>>> drivers/net/wireless/ath/ath9k/xmit.c | 2 +-
>>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>>
>>>> diff --git a/drivers/net/wireless/ath/ath9k/xmit.c
>>>> b/drivers/net/wireless/ath/ath9k/xmit.c
>>>> index 3db1917..09cb13c 100644
>>>> --- a/drivers/net/wireless/ath/ath9k/xmit.c
>>>> +++ b/drivers/net/wireless/ath/ath9k/xmit.c
>>>> @@ -1198,7 +1198,7 @@ void ath_drain_all_txq(struct ath_softc *sc, bool
>>>> retry_tx)
>>>> int r;
>>>>
>>>> ath_print(common, ATH_DBG_FATAL,
>>>> - "Unable to stop TxDMA. Reset HAL!\n");
>>>> + "Failed to stop TX DMA. Resetting
>>>> hardware!\n");
>>>>
>>>> spin_lock_bh(&sc->sc_resetlock);
>>>> r = ath9k_hw_reset(ah, sc->sc_ah->curchan, false);
>>>>
>>>>
>>> Thanks, this is good.
>>>
>>> Luis
>>>
>>>
>>>
>> what about all the signed-off's? should I
>> resend with all of those, or no?
>>
> I do not get what you are asking.
>
> Luis
>
>
all the people that gave there 00.02$ on this to
make it all-good
Justin P. Mattock
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH][RESEND] ath9k: Fix ath_print in xmit for hardware reset.
2010-05-26 18:12 ` Justin P. Mattock
@ 2010-05-26 18:14 ` Luis R. Rodriguez
2010-05-26 18:34 ` Justin P. Mattock
0 siblings, 1 reply; 7+ messages in thread
From: Luis R. Rodriguez @ 2010-05-26 18:14 UTC (permalink / raw)
To: Justin P. Mattock; +Cc: linville, arnd, linux-wireless
On Wed, May 26, 2010 at 11:12 AM, Justin P. Mattock
<justinmattock@gmail.com> wrote:
> On 05/26/2010 11:09 AM, Luis R. Rodriguez wrote:
>> On Wed, May 26, 2010 at 11:07 AM, Justin P. Mattock
>> <justinmattock@gmail.com> wrote:
>>> what about all the signed-off's? should I
>>> resend with all of those, or no?
>
>> I do not get what you are asking.
>
> all the people that gave there 00.02$ on this to
> make it all-good
Heh... no. SOBs are just for the authors of the code. The real purpose
of SOB is explained on Documentation/SubmittingPatches, read
"Developer's Certificate of Origin 1.1".
Luis
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH][RESEND] ath9k: Fix ath_print in xmit for hardware reset.
2010-05-26 18:14 ` Luis R. Rodriguez
@ 2010-05-26 18:34 ` Justin P. Mattock
0 siblings, 0 replies; 7+ messages in thread
From: Justin P. Mattock @ 2010-05-26 18:34 UTC (permalink / raw)
To: Luis R. Rodriguez; +Cc: linville, arnd, linux-wireless
On 05/26/2010 11:14 AM, Luis R. Rodriguez wrote:
> On Wed, May 26, 2010 at 11:12 AM, Justin P. Mattock
> <justinmattock@gmail.com> wrote:
>
>> On 05/26/2010 11:09 AM, Luis R. Rodriguez wrote:
>>
>>> On Wed, May 26, 2010 at 11:07 AM, Justin P. Mattock
>>> <justinmattock@gmail.com> wrote:
>>>
>
>>>> what about all the signed-off's? should I
>>>> resend with all of those, or no?
>>>>
>>
>>> I do not get what you are asking.
>>>
>> all the people that gave there 00.02$ on this to
>> make it all-good
>>
> Heh... no. SOBs are just for the authors of the code. The real purpose
> of SOB is explained on Documentation/SubmittingPatches, read
> "Developer's Certificate of Origin 1.1".
>
> Luis
>
>
I thought you were talking about
Son of a bit*h(was like what's this guy
talkin about man!!
I'll read up today!!
Justin P. Mattock
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2010-05-26 18:33 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-26 18:00 [PATCH][RESEND] ath9k: Fix ath_print in xmit for hardware reset Justin P. Mattock
2010-05-26 18:02 ` Luis R. Rodriguez
2010-05-26 18:07 ` Justin P. Mattock
2010-05-26 18:09 ` Luis R. Rodriguez
2010-05-26 18:12 ` Justin P. Mattock
2010-05-26 18:14 ` Luis R. Rodriguez
2010-05-26 18:34 ` Justin P. Mattock
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).