From: Larry Finger <Larry.Finger@lwfinger.net>
To: Leann Ogasawara <leann.ogasawara@canonical.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
flamingice@sourmilk.net, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] p54usb: Remove duplicate Medion MD40900 device id
Date: Thu, 10 Jun 2010 18:23:19 -0500 [thread overview]
Message-ID: <4C1173E7.6010201@lwfinger.net> (raw)
In-Reply-To: <1276208913.1221.3646.camel@emiko>
On 06/10/2010 05:28 PM, Leann Ogasawara wrote:
> The Medion MD40900 device id [0x0cde, 0x0006] is defined twice. Remove
> the duplicate.
>
> Originally-by: Ben Collins <ben.collins@ubuntu.com>
> Signed-off-by: Leann Ogasawara <leann.ogasawara@canonical.com>
> ---
> drivers/net/wireless/p54/p54usb.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/p54/p54usb.c b/drivers/net/wireless/p54/p54usb.c
> index 7307325..d6d8713 100644
> --- a/drivers/net/wireless/p54/p54usb.c
> +++ b/drivers/net/wireless/p54/p54usb.c
> @@ -69,7 +69,6 @@ static struct usb_device_id p54u_table[] __devinitdata = {
> {USB_DEVICE(0x0915, 0x2002)}, /* Cohiba Proto board */
> {USB_DEVICE(0x0baf, 0x0118)}, /* U.S. Robotics U5 802.11g Adapter*/
> {USB_DEVICE(0x0bf8, 0x1009)}, /* FUJITSU E-5400 USB D1700*/
> - {USB_DEVICE(0x0cde, 0x0006)}, /* Medion MD40900 */
> {USB_DEVICE(0x0cde, 0x0008)}, /* Sagem XG703A */
> {USB_DEVICE(0x0cde, 0x0015)}, /* Zcomax XG-705A */
> {USB_DEVICE(0x0d8e, 0x3762)}, /* DLink DWL-G120 Cohiba */
Do you know for certain that this device is a Version 1 chip, and for
that reason, you are removing it from the version 2 list?
If not, NACK.
Larry
next prev parent reply other threads:[~2010-06-10 23:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-10 22:28 [PATCH] p54usb: Remove duplicate Medion MD40900 device id Leann Ogasawara
2010-06-10 23:23 ` Larry Finger [this message]
2010-06-14 18:55 ` John W. Linville
2010-06-14 19:16 ` Ben Collins
2010-06-15 17:59 ` Leann Ogasawara
2010-06-15 19:46 ` John W. Linville
2010-06-15 23:39 ` [PATCH v2] p54usb: Comment out " Leann Ogasawara
2010-06-18 15:06 ` [PATCH] p54usb: Remove " Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C1173E7.6010201@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=flamingice@sourmilk.net \
--cc=leann.ogasawara@canonical.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).