From: "Justin P. Mattock" <justinmattock@gmail.com>
To: Junchang Wang <junchangwang@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-pci@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 3/5]pci:bus.c Fix variable 'retval' set but not used
Date: Tue, 15 Jun 2010 23:58:11 -0700 [thread overview]
Message-ID: <4C187603.10203@gmail.com> (raw)
In-Reply-To: <20100616060738.GA12461@host-a-229.ustcsz.edu.cn>
On 06/15/2010 11:07 PM, Junchang Wang wrote:
> On Tue, Jun 15, 2010 at 10:33:52PM -0700, Justin P. Mattock wrote:
>> @@ -234,12 +234,10 @@ void pci_bus_add_devices(const struct pci_bus *bus)
>> void pci_enable_bridges(struct pci_bus *bus)
>> {
>> struct pci_dev *dev;
>> - int retval;
>>
>> list_for_each_entry(dev,&bus->devices, bus_list) {
>> if (dev->subordinate) {
>> if (!pci_is_enabled(dev)) {
>> - retval = pci_enable_device(dev);
> Hi Justin,
>
> pci_enable_device initializes device before it's used by a driver.
>
> I think you should add check instead of eliminating pci_enable_device.
>
> For example,
> retval = pci_enable_device(dev);
> if (retval< 0) {
> goto handle_err;
> }
>
> --Junchang
>
>
cool, thanks for the example and info on this. I'll play around with
this to see if I come up with anything.
cheers,
Justin P. Mattock
next prev parent reply other threads:[~2010-06-16 6:57 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-16 5:33 [PATCH 0/5] Fix set but unused variable warnings Justin P. Mattock
2010-06-16 5:33 ` [PATCH 1/5]wireless:hostap_main.c warning: variable 'iface' set but not used Justin P. Mattock
2010-06-16 5:33 ` [PATCH 2/5]wireless:hostap_ap.c Fix warning: variable 'fc' " Justin P. Mattock
2010-06-16 5:33 ` [PATCH 3/5]pci:bus.c Fix variable 'retval' " Justin P. Mattock
2010-06-16 5:42 ` Julian Calaby
2010-06-16 6:56 ` Justin P. Mattock
2010-06-16 6:07 ` Junchang Wang
2010-06-16 6:58 ` Justin P. Mattock [this message]
2010-06-16 17:01 ` Justin P. Mattock
2010-06-17 17:15 ` Justin P. Mattock
2010-06-16 5:33 ` [PATCH 4/5]pci:setup_bus.c Fix warning: " Justin P. Mattock
2010-06-18 17:23 ` Jesse Barnes
2010-06-18 17:31 ` Justin P. Mattock
2010-06-18 18:38 ` Justin P. Mattock
2010-06-18 18:48 ` Yinghai Lu
2010-06-18 19:49 ` Jesse Barnes
2010-06-18 19:59 ` Justin P. Mattock
2010-06-18 20:05 ` Jesse Barnes
2010-06-18 20:26 ` Justin P. Mattock
2010-06-18 20:46 ` Jesse Barnes
2010-06-18 21:12 ` Justin P. Mattock
2010-06-16 5:33 ` [PATCH 5/5]scsi:hosts.c Fix warning: variable 'rval' " Justin P. Mattock
2010-06-16 15:34 ` James Bottomley
2010-06-16 16:00 ` Justin P. Mattock
2010-06-16 17:25 ` Rolf Eike Beer
2010-06-16 17:33 ` James Bottomley
2010-06-16 18:14 ` Justin P. Mattock
2010-06-17 16:16 ` Justin P. Mattock
2010-06-18 19:37 ` James Bottomley
2010-06-18 19:55 ` Justin P. Mattock
2010-06-18 20:17 ` Justin P. Mattock
2010-06-16 5:52 ` [PATCH 0/5] Fix set but unused variable warnings Julian Calaby
2010-06-16 7:01 ` Justin P. Mattock
2010-06-16 11:09 ` Matthew Wilcox
2010-06-16 11:30 ` Julian Calaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C187603.10203@gmail.com \
--to=justinmattock@gmail.com \
--cc=junchangwang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).