linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Felix Fietkau <nbd@openwrt.org>
To: Christian Lamparter <chunkeey@googlemail.com>
Cc: linux-wireless@vger.kernel.org, John W Linville <linville@tuxdriver.com>
Subject: Re: [PATCH] minstrel_ht: fix freeze with legacy hardware
Date: Wed, 14 Jul 2010 23:50:19 +0200	[thread overview]
Message-ID: <4C3E311B.7070402@openwrt.org> (raw)
In-Reply-To: <201007142343.33937.chunkeey@googlemail.com>

On 2010-07-14 11:43 PM, Christian Lamparter wrote:
> Ever since minstrel_ht was prompted to be the default RC,
> I had an this odd freeze in ieee80211_tx_status, 
> whenever I tried to connect my p54*(legacy 11abg) to
> a 802.11n network.
> 
> Apparently, minstrel_ht was not interested if the hardware
> supported 802.11n or not?
> 
> Signed-off-by: Christian Lamparter <chunkeey@googlemail.com>
> ---
> Note: There's another possible way to fix this.
> We can simply AND sta's ht_supported bool with
> the setting in sband's ht_supported.
> 
> The advantage is that we won't need this patch
> and the procedure would "match" to what we did
> with the ht_cap flags.
> 
> This is up for debate... But in the meantime,
> here's a fix.
> 
> P.S.: is there a valid operation situation
> where sta is be NULL, but priv_sta isn't?
Either of those two options is OK with me. I would prefer masking it in
mac80211 though, since the sta ht setting are already partially masked
by hw capabilities.

- Felix

  reply	other threads:[~2010-07-14 21:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-14 21:43 [PATCH] minstrel_ht: fix freeze with legacy hardware Christian Lamparter
2010-07-14 21:50 ` Felix Fietkau [this message]
2010-07-16 11:01   ` [PATCH] mac80211: skip HT parsing if HW does not support HT Christian Lamparter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C3E311B.7070402@openwrt.org \
    --to=nbd@openwrt.org \
    --cc=chunkeey@googlemail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).