From: Kalle Valo <kvalo@adurom.com>
To: Luciano Coelho <luciano.coelho@nokia.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] wl1251: fix sparse-generated warnings
Date: Thu, 22 Jul 2010 11:21:24 +0200 [thread overview]
Message-ID: <4C480D94.9090401@adurom.com> (raw)
In-Reply-To: <1279788739.2322.39.camel@powerslave>
On 07/22/2010 10:52 AM, Luciano Coelho wrote:
> On Thu, 2010-07-22 at 10:45 +0200, ext Kalle Valo wrote:
>> Hi John,
>>
>> On 07/21/2010 06:31 PM, John W. Linville wrote:
>>> @@ -225,7 +225,7 @@ static void wl1251_boot_set_ecpu_ctrl(struct wl1251 *wl, u32 flag)
>>> int wl1251_boot_run_firmware(struct wl1251 *wl)
>>> {
>>> int loop, ret;
>>> - u32 chip_id, interrupt;
>>> + u32 chip_id, acx_intr;
>>
>> I don't get why you did this change. I don't object renaming the
>> variable, but I can't figure out the reasoning behind it.
>
> Sparse complains that interrupt is shadowing the definition in hw_irq.h:
>
>> drivers/net/wireless/wl12xx/wl1251_boot.c:228:22: warning: symbol
>> 'interrupt' shadows an earlier one
>> /home/linville/git/wireless-next-2.6/arch/x86/include/asm/hw_irq.h:132:13: originally declared here
>
> So, it's just a cosmetic change, I guess.
Ah, I was blind as usual. It makes all sense now, thanks.
Kalle
prev parent reply other threads:[~2010-07-22 9:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-21 16:31 [PATCH] wl1251: fix sparse-generated warnings John W. Linville
2010-07-22 6:34 ` Luciano Coelho
2010-07-22 7:38 ` Luciano Coelho
2010-07-22 7:45 ` Kalle Valo
2010-07-22 7:57 ` Luciano Coelho
2010-07-22 12:04 ` Bob Copeland
2010-07-22 13:16 ` John W. Linville
2010-07-22 13:21 ` John W. Linville
2010-07-23 8:14 ` Kalle Valo
2010-07-22 8:45 ` Kalle Valo
2010-07-22 8:52 ` Luciano Coelho
2010-07-22 9:21 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C480D94.9090401@adurom.com \
--to=kvalo@adurom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=luciano.coelho@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).