From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from nbd.name ([88.198.39.176]:58191 "EHLO ds10.nbd.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751029Ab0GVTHI (ORCPT ); Thu, 22 Jul 2010 15:07:08 -0400 Message-ID: <4C4896D5.8010802@openwrt.org> Date: Thu, 22 Jul 2010 21:07:01 +0200 From: Felix Fietkau MIME-Version: 1.0 To: "John W. Linville" CC: Sven Geggus , netdev@vger.kernel.org, linux-wireless@vger.kernel.org Subject: Re: minstrel_tx_status mac80211 WARNINGs in vanilla 2.6.34.1 References: <20100722123000.GA16657@geggus.net> <20100722144723.GA2616@tuxdriver.com> In-Reply-To: <20100722144723.GA2616@tuxdriver.com> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 2010-07-22 4:47 PM, John W. Linville wrote: > On Thu, Jul 22, 2010 at 02:30:01PM +0200, Sven Geggus wrote: >> Hello, >> >> running vanilla 2.6.34.1 I get the following warnings in kernel log: >> >> WARNING: at net/mac80211/rc80211_minstrel.c:70 minstrel_tx_status+0x67/0xd1 [mac80211]() >> Hardware name: SCENIC E300/E600 >> Modules linked in: i915 drm_kms_helper drm video backlight output lp loop >> snd_intel8x0 snd_ac97_codec ac97_bus snd_pcm_oss snd_mixer_oss snd_pcm >> snd_seq_dummy zd1211rw snd_seq_oss usbhid mac80211 option cfg80211 >> snd_seq_midi usbserial snd_rawmidi snd_seq_midi_event snd_seq snd_timer >> snd_seq_device snd parport_pc ehci_hcd uhci_hcd soundcore intel_agp parport >> usbcore nls_base snd_page_alloc agpgart rng_core floppy sg >> Pid: 0, comm: swapper Tainted: G W 2.6.34.1 #3 >> Call Trace: >> [] warn_slowpath_common+0x60/0x90 >> [] warn_slowpath_null+0xd/0x10 >> [] minstrel_tx_status+0x67/0xd1 [mac80211] >> [] ieee80211_tx_status+0x1f6/0x5ac [mac80211] >> [] ? skb_dequeue+0x45/0x4c >> [] ieee80211_tasklet_handler+0x61/0xd6 [mac80211] >> [] tasklet_action+0x62/0x9f >> [] __do_softirq+0x77/0xe5 >> [] do_softirq+0x26/0x2b >> [] irq_exit+0x29/0x66 >> [] do_IRQ+0x85/0x9b >> [] common_interrupt+0x29/0x30 >> [] ? default_idle+0x2d/0x42 >> [] cpu_idle+0x44/0x71 >> [] rest_init+0x96/0x98 >> [] start_kernel+0x2a5/0x2aa >> [] i386_start_kernel+0xb7/0xbf >> ---[ end trace f22ceacef336878f ]--- >> >> Wireless driver is zd1211rw. >> >> Did not test with older kernel because this device has not been in user on >> this machine before. >> >> WLAN does however seem to work anyway. > > Well, I just took a quick look -- so, I'm not 100% sure... > > But, it looks to me like zd1211rw is reporting tx status on a rate > that minstrel didn't expect it to use. It seems like the hardware > is pre-wired to do retries on sequentially lower rates, which seems > a bit incompatible with minstrel's worldview. > > Felix, can we accomodate this? The "WLAN does however seem to work > anyway" seems to suggest things work, so can we at least not yell > about it? I think we should just drop that WARN_ON(). It's not problematic if minstrel gets feedback for rates that it doesn't have in its list, it should just ignore it. - Felix