Re: [PATCH v5] cfg80211: Add nl80211 antenna configuration

[Felix Fietkau <nbd@openwrt.org>]

On 2010-08-02 11:52 AM, Luis R. Rodriguez wrote:
> On Mon, Aug 2, 2010 at 2:32 AM, Felix Fietkau <nbd@openwrt.org> wrote:
>> On 2010-08-02 11:23 AM, Luis R. Rodriguez wrote:
>>> Sure, I just did not see any code for this in these patches. My point
>>> about the hw config vs fake/mod'd is if we'd expose the mod'd config
>>> changes to userspace or if we'd keep them internal to cfg80211. How
>>> would this be dealt with?
>> Right now, cfg80211 doesn't know enough to handle this stuff on its own,
>> so let's handle it in the driver completely on the first iteration. The
>> patches do not need any changes for this right now.
> 
> I'd prefer that code to be written rather then let this be defined as
> API now and let drivers deal with this differently. But that's me, I'm
> not the maintainer, I just will not deal with bug reports dealing with
> this and I'll assign them to you guys if this gets through. Still
> think its crap and should just go through debugfs until all the code
> mentioned does exist.
Sorry, but WTF? There's two parts to this: API visible to user space,
and the internal API for handling changes.
So you're suggesting to reject the user space API, because of missing
parts in the internal API (which we can change any time) that will only
be used for drivers that this series doesn't even contain any code for??
Am I confused here, or does this seem rather strange?

- Felix