From: Felix Fietkau <nbd@openwrt.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "Luis R. Rodriguez" <mcgrof@gmail.com>,
Bruno Randolf <br1@einfach.org>,
linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v5] cfg80211: Add nl80211 antenna configuration
Date: Mon, 02 Aug 2010 13:19:07 +0200 [thread overview]
Message-ID: <4C56A9AB.8030801@openwrt.org> (raw)
In-Reply-To: <1280746893.3923.12.camel@jlt3.sipsolutions.net>
On 2010-08-02 1:01 PM, Johannes Berg wrote:
> On Mon, 2010-08-02 at 12:47 +0200, Felix Fietkau wrote:
>
>> Legacy hardware => run time changes possible (actually optional)
>> 802.11n hardware => need to bring down the interface before changing
>> the antenna settings
>
> I think I'd prefer if all hw just required the device to be stopped.
> Otherwise things either become awkward when you have, say. software
> diversity control, or they become unpredictable quite, no?
If the driver does something like that, then the antenna control
callback should reset that state as well. But then again, I don't mind
if legacy hw requires the interface to be down as well.
- Felix
prev parent reply other threads:[~2010-08-02 11:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-29 3:58 [PATCH v5] cfg80211: Add nl80211 antenna configuration Bruno Randolf
2010-07-29 6:12 ` Luis R. Rodriguez
2010-07-29 7:48 ` Johannes Berg
2010-07-29 9:12 ` Bruno Randolf
2010-07-29 15:04 ` Luis R. Rodriguez
2010-08-02 4:13 ` Bruno Randolf
2010-08-02 5:37 ` Luis R. Rodriguez
2010-08-02 8:59 ` Felix Fietkau
2010-08-02 9:10 ` Luis R. Rodriguez
2010-08-02 9:17 ` Felix Fietkau
2010-08-02 9:23 ` Luis R. Rodriguez
2010-08-02 9:32 ` Felix Fietkau
2010-08-02 9:52 ` Luis R. Rodriguez
2010-08-02 10:10 ` Felix Fietkau
2010-08-02 10:18 ` Luis R. Rodriguez
2010-08-02 10:47 ` Felix Fietkau
2010-08-02 10:51 ` Luis R. Rodriguez
2010-08-02 11:18 ` Felix Fietkau
2010-08-02 17:45 ` Luis R. Rodriguez
2010-08-02 11:01 ` Johannes Berg
2010-08-02 11:19 ` Felix Fietkau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C56A9AB.8030801@openwrt.org \
--to=nbd@openwrt.org \
--cc=br1@einfach.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).