From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from nbd.name ([88.198.39.176]:43056 "EHLO ds10.nbd.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752680Ab0HBLTJ (ORCPT ); Mon, 2 Aug 2010 07:19:09 -0400 Message-ID: <4C56A9AB.8030801@openwrt.org> Date: Mon, 02 Aug 2010 13:19:07 +0200 From: Felix Fietkau MIME-Version: 1.0 To: Johannes Berg CC: "Luis R. Rodriguez" , Bruno Randolf , linville@tuxdriver.com, linux-wireless@vger.kernel.org Subject: Re: [PATCH v5] cfg80211: Add nl80211 antenna configuration References: <20100729035820.5930.29864.stgit@tt-desk> <201007291812.28639.br1@einfach.org> <201008021313.54850.br1@einfach.org> <4C5688F7.1070200@openwrt.org> <4C568D23.2000203@openwrt.org> <4C5690C7.2080104@openwrt.org> <4C5699AE.6090103@openwrt.org> <4C56A251.7080903@openwrt.org> <1280746893.3923.12.camel@jlt3.sipsolutions.net> In-Reply-To: <1280746893.3923.12.camel@jlt3.sipsolutions.net> Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 2010-08-02 1:01 PM, Johannes Berg wrote: > On Mon, 2010-08-02 at 12:47 +0200, Felix Fietkau wrote: > >> Legacy hardware => run time changes possible (actually optional) >> 802.11n hardware => need to bring down the interface before changing >> the antenna settings > > I think I'd prefer if all hw just required the device to be stopped. > Otherwise things either become awkward when you have, say. software > diversity control, or they become unpredictable quite, no? If the driver does something like that, then the antenna control callback should reset that state as well. But then again, I don't mind if legacy hw requires the interface to be down as well. - Felix