From: Felix Fietkau <nbd@openwrt.org>
To: Michael Griepentrog <michael.griepentrog@gmail.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [mac80211] minstrel_ht rate population
Date: Tue, 17 Aug 2010 20:22:13 +0200 [thread overview]
Message-ID: <4C6AD355.7010509@openwrt.org> (raw)
In-Reply-To: <AANLkTi=axa4jxYCodm4mhedtnauPzr5AJvD5Z2GssWdc@mail.gmail.com>
On 2010-08-17 7:37 PM, Michael Griepentrog wrote:
> Hi,
>
> I'm looking at minstrel_ht_get_rate() from the latest git, and I
> noticed that the rates are getting set into info->status.rates. Is
> this correct? My impression was that array gets populated by the
> driver after a successful transmission. ath9k's rate control algorithm
> uses the expected tx_info->control.rates. Minstrel_ht appears to still
> work, am I missing something?
That's technically a bug (I'll send a fix for this soon), but it doesn't
matter in practice, as info->control.rates always points to the same
location as info->status.rates.
- Felix
prev parent reply other threads:[~2010-08-17 18:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-17 17:37 [mac80211] minstrel_ht rate population Michael Griepentrog
2010-08-17 18:22 ` Felix Fietkau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C6AD355.7010509@openwrt.org \
--to=nbd@openwrt.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michael.griepentrog@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).