From: "Michael Büsch" <mb@bu3sch.de>
To: "Gábor Stefanik" <netrolller.3d@gmail.com>,
"Rafał Miłecki" <zajec5@gmail.com>
Cc: wireless <linux-wireless@vger.kernel.org>,
b43-dev <b43-dev@lists.infradead.org>
Subject: Re: [PATCH 2/2] b43: N-PHY: add sub calls of band width setting
Date: Wed, 25 Aug 2010 21:07:32 +0200 [thread overview]
Message-ID: <4C7569F4.7020605@bu3sch.de> (raw)
In-Reply-To: <AANLkTi=ELhn1sFmpYn5a1-GcWqVBAeRGC6Kc7OBDLmZw@mail.gmail.com> (sfid-20100822_160429_404901_8D578590)
On 08/22/2010 10:04 PM, Gábor Stefanik wrote:
>>>> +#define B43_MMIO_CLKCTL 0x1E0 /* clock control status */
Is it possible that all this stuff is completely bogus?
All this clock control stuff you are trying to implement really
looks like the standard SSB clock control which is already
implemented in SSB. The clock control and status register
of the chipcommon is 0x1E0.
That "phy reset" stuff also mostly looks like you are reinventing the wheel
for code that is already present.
--
Greetings Michael.
next prev parent reply other threads:[~2010-08-25 19:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-22 19:49 [PATCH 1/2] b43: N-PHY: band width setting with dumb clock control call Rafał Miłecki
2010-08-22 19:49 ` [PATCH 2/2] b43: N-PHY: add sub calls of band width setting Rafał Miłecki
2010-08-22 19:52 ` Gábor Stefanik
2010-08-22 19:58 ` Rafał Miłecki
2010-08-22 20:04 ` Gábor Stefanik
2010-08-22 20:14 ` Rafał Miłecki
2010-08-22 20:29 ` Larry Finger
2010-08-25 19:07 ` Michael Büsch [this message]
2010-08-22 23:20 ` [PATCH 1/2] b43: N-PHY: band width setting with dumb clock control call Julian Calaby
2010-08-22 23:30 ` Gábor Stefanik
2010-08-22 23:37 ` Rafał Miłecki
2010-08-23 22:53 ` Rafał Miłecki
2010-08-23 23:17 ` Larry Finger
2010-08-23 23:56 ` Gábor Stefanik
2010-08-22 23:35 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C7569F4.7020605@bu3sch.de \
--to=mb@bu3sch.de \
--cc=b43-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netrolller.3d@gmail.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).