From: Ben Greear <greearb@candelatech.com>
To: Felix Fietkau <nbd@openwrt.org>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [virtual-sta 3/3] mac80211: Allow multiple STA on same BSS.
Date: Fri, 10 Sep 2010 15:49:46 -0700 [thread overview]
Message-ID: <4C8AB60A.2060409@candelatech.com> (raw)
In-Reply-To: <4C8AB4BD.5090204@openwrt.org>
On 09/10/2010 03:44 PM, Felix Fietkau wrote:
> On 2010-09-10 3:04 PM, greearb@candelatech.com wrote:
>> From: Ben Greear<greearb@candelatech.com>
>>
>> When adding an STA, the old code checked if there was already
>> an STA with the same BSS. Instead, check to see if there is
>> exactly the same STA in order to allow multiple STA to be
>> associated with the same AP.
> I think that's misleading. sta_info_get_bss does not check if there is a
> STA with the same BSS. Like sta_info_get it looks for a STA with the
> given address, but unlike sta_info_get, it also accepts it if it's on a
> different interface than the provided sdata, but part of the same BSS as
> the sdata's.
> Because of that, this change seems bogus to me.
W/out this change, I cannot get a second STA to associate with
the AP because that code returns EBUSY, because the
first STA and second STA point to the same bss.
There could be a better way to do what I'm trying to do,
but that one-line patch made it work for me. I'll be happy
to try alternative suggestions.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2010-09-10 22:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-10 22:04 [virtual-sta 1/3] mac80211: Add more general interface iterator greearb
2010-09-10 22:04 ` [virtual-sta 2/3] ath9k: Calculate bssid-mask and rxfilter for 2+ STAs greearb
2010-09-10 22:04 ` [virtual-sta 3/3] mac80211: Allow multiple STA on same BSS greearb
2010-09-10 22:44 ` Felix Fietkau
2010-09-10 22:49 ` Ben Greear [this message]
2010-09-10 22:54 ` Felix Fietkau
2010-09-14 12:57 ` Johannes Berg
2010-09-14 15:45 ` Ben Greear
2010-09-14 12:59 ` [virtual-sta 1/3] mac80211: Add more general interface iterator Johannes Berg
2010-09-14 14:47 ` Ben Greear
2010-09-14 14:53 ` Johannes Berg
2010-09-14 15:26 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C8AB60A.2060409@candelatech.com \
--to=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).