From: Ben Greear <greearb@candelatech.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [virtual-sta 1/3] mac80211: Add more general interface iterator.
Date: Tue, 14 Sep 2010 07:47:41 -0700 [thread overview]
Message-ID: <4C8F8B0D.8050902@candelatech.com> (raw)
In-Reply-To: <1284469166.3704.3.camel@jlt3.sipsolutions.net>
On 09/14/2010 05:59 AM, Johannes Berg wrote:
> On Fri, 2010-09-10 at 15:04 -0700, greearb@candelatech.com wrote:
>
>> This allows callers to specify whether they want all
>> or just active interfaces,
>
> I thought about this, and I don't want to allow drivers to get at
> inactive interfaces. And with that, I don't think there's a need to
> restructure the code here. Also, since what you wanted wasn't the count
> but the STA interface count, you need your own iterator function anyway,
> no?
I'll see if I can get ath9k to use the normal iterator. I didn't need my
own iterator, because I could just pass in NULL for iterator and pass
active_only as false.
I think you should consider returning the count for the number of times the
iterator was called because it's simple code, and it would save the same logic
in each driver's iterator methods (or at least, ath9k).
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2010-09-14 14:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-10 22:04 [virtual-sta 1/3] mac80211: Add more general interface iterator greearb
2010-09-10 22:04 ` [virtual-sta 2/3] ath9k: Calculate bssid-mask and rxfilter for 2+ STAs greearb
2010-09-10 22:04 ` [virtual-sta 3/3] mac80211: Allow multiple STA on same BSS greearb
2010-09-10 22:44 ` Felix Fietkau
2010-09-10 22:49 ` Ben Greear
2010-09-10 22:54 ` Felix Fietkau
2010-09-14 12:57 ` Johannes Berg
2010-09-14 15:45 ` Ben Greear
2010-09-14 12:59 ` [virtual-sta 1/3] mac80211: Add more general interface iterator Johannes Berg
2010-09-14 14:47 ` Ben Greear [this message]
2010-09-14 14:53 ` Johannes Berg
2010-09-14 15:26 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C8F8B0D.8050902@candelatech.com \
--to=greearb@candelatech.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).