Re: [virtual-sta 3/3] mac80211: Allow multiple STA on same BSS.

[Ben Greear <greearb@candelatech.com>]

On 09/14/2010 05:57 AM, Johannes Berg wrote:
> On Fri, 2010-09-10 at 15:04 -0700, greearb@candelatech.com wrote:
>> From: Ben Greear<greearb@candelatech.com>
>>
>> When adding an STA, the old code checked if there was already
>> an STA with the same BSS.  Instead, check to see if there is
>> exactly the same STA in order to allow multiple STA to be
>> associated with the same AP.
>
>
> You want this instead:
>
> ---
>   net/mac80211/sta_info.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- wireless-testing.orig/net/mac80211/sta_info.c	2010-09-14 14:53:10.000000000 +0200
> +++ wireless-testing/net/mac80211/sta_info.c	2010-09-14 14:55:44.000000000 +0200
> @@ -125,7 +125,7 @@ struct sta_info *sta_info_get_bss(struct
>   				    lockdep_is_held(&local->sta_mtx));
>   	while (sta) {
>   		if ((sta->sdata == sdata ||
> -		     sta->sdata->bss == sdata->bss)&&
> +		     (sta->sdata->bss&&  sta->sdata->bss == sdata->bss))&&
>   		memcmp(sta->sta.addr, addr, ETH_ALEN) == 0)
>   			break;
>   		sta = rcu_dereference_check(sta->hnext,

This seems to work fine.  Do you want me to respin the patch, or will you push this
in?

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com