From: Felix Fietkau <nbd@openwrt.org>
To: Ben Greear <greearb@candelatech.com>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com,
johannes@sipsolutions.net, lrodriguez@atheros.com
Subject: Re: [PATCH 1/2] ath9k: fix BSSID mask calculation
Date: Tue, 14 Sep 2010 20:06:17 +0200 [thread overview]
Message-ID: <4C8FB999.1020200@openwrt.org> (raw)
In-Reply-To: <4C8FB81A.7090007@candelatech.com>
On 2010-09-14 7:59 PM, Ben Greear wrote:
> It seems I saw this code over-write the mask with a bad value
> when debugging this a few days ago..but perhaps I was mistaken,
> or perhaps your patch fixes this already.
>
> /* configure bssid mask */
> if (ah->caps.hw_caps & ATH9K_HW_CAP_BSSIDMASK)
> ath_hw_setbssidmask(common);
>
> My plan was to have it call ath9k_set_bssid_mask(common->hw) instead.
Not necessary. The bssid mask only needs to be recalculated when
interfaces are brought up (and maybe when they are brought down, but
that's less important).
The code here only needs to apply the precalculated mask to the hardware.
> Were you able to create multiple STA interfaces and have them
> send/receive data with your patch?
I did not test that, but I suspect that my changes help there as well.
- Felix
next prev parent reply other threads:[~2010-09-14 18:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-14 16:37 [PATCH 1/2] ath9k: fix BSSID mask calculation Felix Fietkau
2010-09-14 16:37 ` [PATCH 2/2] mac80211: add a note about iterating interfaces during add_interface() Felix Fietkau
2010-09-14 17:33 ` [PATCH 1/2] ath9k: fix BSSID mask calculation Ben Greear
2010-09-14 17:51 ` Felix Fietkau
2010-09-14 17:59 ` Ben Greear
2010-09-14 18:06 ` Felix Fietkau [this message]
2010-09-14 19:18 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C8FB999.1020200@openwrt.org \
--to=nbd@openwrt.org \
--cc=greearb@candelatech.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).