linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Felix Fietkau <nbd@openwrt.org>
To: Rajkumar Manoharan <rmanoharan@atheros.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath9k_htc: Fix beacon distribution in IBSS mode
Date: Mon, 20 Sep 2010 14:42:54 +0200	[thread overview]
Message-ID: <4C9756CE.1060908@openwrt.org> (raw)
In-Reply-To: <1284985872-31021-1-git-send-email-rmanoharan@atheros.com>

On 2010-09-20 2:31 PM, Rajkumar Manoharan wrote:
> This patch ensures fair beacon distribution in IBSS mode
> by configuring proper CWmin based on slot time.
> 
> Signed-off-by: Rajkumar Manoharan <rmanoharan@atheros.com>
> ---
>  drivers/net/wireless/ath/ath9k/htc_drv_beacon.c |    9 +++++-
>  drivers/net/wireless/ath/ath9k/hw.c             |   32 +++++++++++++++++++++++
>  drivers/net/wireless/ath/ath9k/hw.h             |    1 +
>  3 files changed, 41 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_beacon.c b/drivers/net/wireless/ath/ath9k/htc_drv_beacon.c
> index bd1506e..3e699a5 100644
> --- a/drivers/net/wireless/ath/ath9k/htc_drv_beacon.c
> +++ b/drivers/net/wireless/ath/ath9k/htc_drv_beacon.c
> @@ -235,7 +235,14 @@ void ath9k_htc_beaconq_config(struct ath9k_htc_priv *priv)
>  	ath9k_hw_get_txq_props(ah, qnum, &qi_be);
>  
>  	qi.tqi_aifs = qi_be.tqi_aifs;
> -	qi.tqi_cwmin = 4*qi_be.tqi_cwmin;
> +	/* For WIFI Beacon Distribution
> +	 * Long slot time  : 2x cwmin
> +	 * Short slot time : 4x cwmin
> +	 */
> +	if (ath9k_hw_getslottime(ah) == ATH9K_SLOT_TIME_20)
I'd recommend using ah->slottime here and dropping all of those ath9k_hw
changes.

- Felix

  reply	other threads:[~2010-09-20 12:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-20 12:31 [PATCH] ath9k_htc: Fix beacon distribution in IBSS mode Rajkumar Manoharan
2010-09-20 12:42 ` Felix Fietkau [this message]
2010-09-21  7:26   ` Rajkumar Manoharan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C9756CE.1060908@openwrt.org \
    --to=nbd@openwrt.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=rmanoharan@atheros.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).